Bug 380482

Summary: krita on Windows not compiling with master for me
Product: [Applications] krita Reporter: Scott Petrovic <scottpetrovic>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/krita/bcc6db00f5a809d180de2803f01418f0a3817fea Version Fixed/Implemented In:
Sentry Crash Report:

Description Scott Petrovic 2017-06-02 18:04:01 UTC 
I did a clean build on master latest and it wasn't compiling with an error about -w and winres.exe. I moved around quite a few commits and think I pinpointed it to this commit.

Author:		Dmitry Kazakov <dimula73@gmail.com>
Date:		3 weeks ago (5/10/2017 2:28:59 AM)
Commit hash:	53a506aa625c356f758cec68e0819e39b45dc497
Children:	8852506e8e
Parent(s):	532deabb79

Add -Werror=delete-incomplete

Deletion of an incomplete type is extremely dangerous and usually
causes memory leaks, so just make it a build error instead, so we
couldn't miss it.



This is the line that I think is having the issue...

if (CMAKE_COMPILER_IS_GNUCXX AND NOT CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.9)
    add_definitions(-Werror=delete-incomplete)
endif()


I am on Windows and cmake version 3.4.3. Commenting out these lines makes my windows build fine, so I imagine there might be something with the if statement logic that might not be right.
Comment 1 Halla Rempt 2017-06-05 10:04:13 UTC 
The check is for the gcc version, not the cmake version. But it does mess up the windows build for some reason...
Comment 2 Halla Rempt 2017-06-05 10:05:05 UTC 
Git commit bcc6db00f5a809d180de2803f01418f0a3817fea by Boudewijn Rempt.
Committed on 05/06/2017 at 10:04.
Pushed by rempt into branch 'master'.

Only add the -Werror on Linux

On Windows, this messes up the build system for some reason... It
breaks the call to winres!

M  +4    -2    CMakeLists.txt

https://commits.kde.org/krita/bcc6db00f5a809d180de2803f01418f0a3817fea