Bug 380435

Summary: Latest kirigami 2 from master breaks discover & new systemsettings sidebar view in Qt 5.7.1
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Rik Mills <rikmills>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: major CC: jr
Priority: NOR    
Version: Master   
Target Milestone: Not decided   
Platform: Neon   
OS: Linux   
Latest Commit: https://commits.kde.org/kirigami/655bdb21b9185268b87a1ca60a0bf0ec1a563104 Version Fixed In:
Attachments: breakage

Description Rik Mills 2017-06-01 18:06:06 UTC 
Created attachment 105825 [details]
breakage

Latest kirigami 2 from master breaks discover & new systemsettings sidebar view in Qt 5.7.1

This is evident on both Neon and Kubuntu CI builds.

1st bad commit appears on bisection to be:

https://cgit.kde.org/kirigami.git/commit/?id=0d0755f3d402270a809652b74b656a0ba3e5742c

No compilation warnings about any incompatibility with Qt 5.7 are shown, if this is deliberate.
Comment 1 Rik Mills 2017-06-01 18:20:07 UTC 
Please also see the paste below of the console output shown in the attached screenshot

https://paste.kde.org/phpjhvzj7
Comment 2 Aleix Pol 2017-06-02 11:31:07 UTC 
Git commit 655bdb21b9185268b87a1ca60a0bf0ec1a563104 by Aleix Pol.
Committed on 02/06/2017 at 11:29.
Pushed by apol into branch 'master'.

Fix issue in Qt 5.7

Summary:
qml parser doesn't like having namespaced object types in the declaration
of a property. Use QtObject instead.

Test Plan:
Tests pass, applied it on my neon machine (sudo vim /usr...) and
it seemed to work

Reviewers: #kirigami, jriddell, davidedmundson

Reviewed By: davidedmundson

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D6065

M  +1    -1    src/styles/org.kde.desktop.plasma/Units.qml
M  +1    -1    src/styles/org.kde.desktop/Units.qml

https://commits.kde.org/kirigami/655bdb21b9185268b87a1ca60a0bf0ec1a563104