Bug 380340 (Altguard)

Summary: Eraser mode does not reset after using outline selection tool
Product: [Applications] krita Reporter: Altguard <altguard>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: minor CC: freebox64, halla
Priority: NOR    
Version First Reported In: 3.1.4   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/krita/76f2dc328eee544d67535a83895841b2371746cc Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Video

Description Altguard 2017-05-30 03:54:02 UTC 
Overview:

Using a brush in eraser mode, switching to the outline selection tool, then switching back to the freehand brush tool, results in the eraser mode icon appearing as if eraser mode is off, but the brush will still be in eraser mode

Steps to Reproduce:

1) Select a brush, draw a stroke
2) Enable Eraser Mode, erase a bit of the stroke.
3) Select Outline Selection Tool.
4) Select Freehand Brush Tool. the Eraser Mode icon will now show as disabled.
5) Attempt to draw a stroke. This will result in nothing happening.
6) Attempt to draw a stroke over a previous stroke. This will erase the previous stroke, despite Eraser Mode displaying as disabled.

Actual Results:

The brush remains in eraser mode, but the eraser mode icon displays itself as disabled.

Expected Results:

The brush state matches the eraser mode icon, and is not in eraser mode.

Build Date & Platform:

2017-05-29 on Linux 4.11.2-1-ARCH
Comment 1 mvowada 2017-05-30 07:40:34 UTC 
Created attachment 105773 [details]
Video

Yes, I think I can confirm this behaviour on Ubuntu 14.04 with Krita 3.1.4 appimage.
Comment 2 Halla Rempt 2017-06-06 07:42:35 UTC 
Yes, I can see this happen as well.
Comment 3 joupent 2017-12-11 16:10:22 UTC 
Git commit a6a6626be6e995082d009c98f3a8cf1c2ed91fa4 by Jouni Pentikäinen.
Committed on 11/12/2017 at 16:09.
Pushed by jounip into branch 'master'.

Fix erase mode not showing correctly when returning to brush tool

M  +1    -1    libs/ui/kis_paintop_box.cc

https://commits.kde.org/krita/a6a6626be6e995082d009c98f3a8cf1c2ed91fa4
Comment 4 Halla Rempt 2017-12-22 12:47:51 UTC 
Git commit 76f2dc328eee544d67535a83895841b2371746cc by Boudewijn Rempt, on behalf of Jouni Pentikäinen.
Committed on 22/12/2017 at 12:45.
Pushed by rempt into branch 'krita/3.3'.

Fix erase mode not showing correctly when returning to brush tool

M  +1    -1    libs/ui/kis_paintop_box.cc

https://commits.kde.org/krita/76f2dc328eee544d67535a83895841b2371746cc