Bug 380244

Summary: Created OpenConnect (Juniper) connection is incompatible with nm-connection-editor
Product: [Applications] systemsettings Reporter: Eugene Paskevich <eugene>
Component: kcm_networkmanagementAssignee: Jan Grulich <jgrulich>
Status: RESOLVED FIXED    
Severity: normal CC: jgrulich
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Debian unstable   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.10.1
Sentry Crash Report:
Attachments: Proposed patch

Description Eugene Paskevich 2017-05-27 01:49:19 UTC
Env: all KDE components are from Debian unstable, only plasma-nm is built from master (v5.9.95-3-g743fec5a).

When new OpenConnect (Juniper) connection is created, plasma-nm sets the vpn.data protocol=juniper, which is incompatible with the rest nm tools.

And vice-versa. If connection is created by nm-connection-editor, it sets protocol=nc, which isn't recognized by plasma-nm.

Please make sure to stay compatible with the rest of nm tools.
Comment 1 Eugene Paskevich 2017-05-27 03:26:49 UTC
Created attachment 105727 [details]
Proposed patch
Comment 2 Jan Grulich 2017-05-30 07:13:40 UTC
Git commit 7fe2a9622b24667cd5ad1c78e85fae9b4e14e264 by Jan Grulich.
Committed on 30/05/2017 at 07:13.
Pushed by grulich into branch 'master'.

Openconnect (juniper): Make sure we are compatible with the rest of nm tools

M  +1    -1    vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop

https://commits.kde.org/plasma-nm/7fe2a9622b24667cd5ad1c78e85fae9b4e14e264
Comment 3 Jan Grulich 2017-05-30 07:14:12 UTC
Git commit e52c259c2e7ca52b27c23aef6c018c579600e4b2 by Jan Grulich.
Committed on 30/05/2017 at 07:13.
Pushed by grulich into branch 'Plasma/5.10'.

Openconnect (juniper): Make sure we are compatible with the rest of nm tools

M  +1    -1    vpn/openconnect/plasmanetworkmanagement_openconnect_juniperui.desktop

https://commits.kde.org/plasma-nm/e52c259c2e7ca52b27c23aef6c018c579600e4b2
Comment 4 Eugene Paskevich 2017-05-30 10:08:42 UTC
Thank you for considering this report!

I'm not sure why you omitted the first part of the patch though. For me it seems that with current code the protocol=nc dataMap would become protocol=anyconnect in d->vpninfo. Which is most probably not a desired effect.

Could you please take a closer look at this part of the code?
Comment 5 Jan Grulich 2017-05-30 10:18:41 UTC
You are right, I didn't realize that. I'll fix it.