| Summary: | Speed labels and speed graph empty after showing the applet twice | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Elvis Angelaccio <elvis.angelaccio> |
| Component: | DataEngines | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | eugene.shalygin+bugzilla.kde, jgrulich, kde |
| Priority: | NOR | ||
| Version: | 5.8.7 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/f060ad5f1ad06359088887cb2f7e691c994ccfc5 | Version Fixed In: | 5.8.8, 5.10.1 |
| Sentry Crash Report: | |||
| Attachments: | Empty speed graph | ||
|
Description
Elvis Angelaccio
2017-05-25 22:22:11 UTC
Created attachment 105717 [details]
Empty speed graph
Screenshot of the empty speed graph after the bug occurs.
(In reply to Elvis Angelaccio from comment #0) > When expanding the connection item to show the graph, I get this output: > > file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ > ui/ConnectionItem.qml:193:26: Unable to assign [undefined] to bool > file:///usr/share/plasma/plasmoids/org.kde.plasma.networkmanagement/contents/ > ui/ConnectionItem.qml:193:26: Unable to assign [undefined] to bool Further debug prints show that: qml: dataSource.data[dataSource.downloadSource]: undefined qml: dataSource.data[dataSource.uploadSource]: undefined hmm this looks like a bug in the systemmonitor data engine. I have a patch that seems to fix it. Thank you!! Close this bug please once your patch is upstreamed. Git commit f060ad5f1ad06359088887cb2f7e691c994ccfc5 by Elvis Angelaccio. Committed on 26/05/2017 at 09:25. Pushed by elvisangelaccio into branch 'Plasma/5.8'. Always add data sources in SystemMonitorEngine::sourceRequestEvent() Summary: Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty and we won't be able to fect the connection speed data. git blame points to https://github.com/KDE/kde-workspace/commit/ba7444f99ab08cf0a305899bf66879314bd0d5a9 and https://github.com/KDE/kde-workspace/commit/235fea1868b560acf32c5c13a3d16ef233b50be6 but they don't really explain why setData() was called only if m_sensors was empty. Test Plan: - plasmoidviewer -a org.kde.plasma.networkmanagement - open the networkmanager applet twice - make sure the connection's speed graph works the 2nd time. Reviewers: #plasma, jgrulich Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D5973 M +2 -12 dataengines/systemmonitor/systemmonitor.cpp https://commits.kde.org/plasma-workspace/f060ad5f1ad06359088887cb2f7e691c994ccfc5 Jan, is bug 356841 a duplicate? Possibly. You can close it as a duplicate and if it's not, then the reporter can re-open it after he tries fixed plasma-workspace. Yeah it's the same bug. Sorry I didn't know there was already a report. *** Bug 356841 has been marked as a duplicate of this bug. *** |