| Summary: | "Open with" menu entry missing [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | philippe weyland <philippe.weyland> |
| Component: | Usability-OpenWith | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aegoreev, caulier.gilles, eric.picel, freisim93, mail, metzpinguin |
| Priority: | NOR | ||
| Version: | 5.5.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/digikam/4b55d48e5500feb59c2564ae6fc1e0672c77ff29 | Version Fixed In: | 6.1.0 |
| Sentry Crash Report: | |||
| Attachments: |
Click-Right menu under windows - "open with" missing
Open with for single file on windows Update patch to support native Open With under Windows. Update patch to support native Open With under Windows (version 3). |
||
OpenWith feature use KIO API from KDE and is Linux only. Under MAcOS and Windows, this do not work. In fact KIO is disabled outside Linux. Gilles Caulier OK, the answer is clear. But ... Is this not a showstopper for using Digikam along with any other image editor ? Philippe Certainly, I try to find how non KDE application (and portable) try to deal with Open With feature... It's not simple... Wait and see Gilles Caulier I wish you success :-) *** Bug 383079 has been marked as a duplicate of this bug. *** *** Bug 374356 has been marked as a duplicate of this bug. *** The port to QT has happened, but there might still be a problem on Windows (see cited post below). Can you please test with the pre-release and report back whether it works or not: https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM From a duplicated issue: (In reply to caulier.gilles from bug 374356 comment #4) > File/Open in file explorer is already implemented, through QDesktopService, > but it sound like under Windows, the Qt wrapper do not do the job properly. > > Can you confirm this ? The last build for Windows use Qt 5.9 (previous one > Qt 5.7). Perhaps the situation has changed now... > > https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM > > Gilles Caulier (In reply to Simon from comment #7) > The port to QT has happened, but there might still be a problem on Windows > (see cited post below). Can you please test with the pre-release and report > back whether it works or not: > https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM > > From a duplicated issue: > > (In reply to caulier.gilles from bug 374356 comment #4) > > File/Open in file explorer is already implemented, through QDesktopService, > > but it sound like under Windows, the Qt wrapper do not do the job properly. > > > > Can you confirm this ? The last build for Windows use Qt 5.9 (previous one > > Qt 5.7). Perhaps the situation has changed now... > > > > https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM > > > > Gilles Caulier Still missing. Here is the options I see: Right click - Open (F4) - opens Editor Menu - Item - Open (F4) - same Menu - Item - Open with Default Application (Meta + F4) - opens windows viewer "Open with" is still missing Andrius checked, so: I confirm that version 5.7 beta doesn't bring (yet) the entry "Open with" (Windows 10) OpenWith feature require KIO slave from KDE. This do not work under Windows or require a complex run time puzzle that i don't want to solve in the bundle. Also, the OpenWith feature will only provide external tool from Unix world, not Windows. So we need a native Windows solution to reproduce the feature. Note : It's exactly the same problem under MacOS. Gilles Caulier Created attachment 107063 [details] Open with for single file on windows This is based on a quick google search turning up this SO question: https://stackoverflow.com/questions/6364879/how-to-open-a-default-dialog-for-window-if-shellexecute-fails-due-to-no-file-ass Maybe this just works, but I wouldn't get my hopes up and I can't test myself. Hi Simon, I do not have a windows computer to test here. The patch sound like not too intrusive. I recommend to move Windows API code to a dedicated cpp file (as Qt implementation do). Something like /app/utils/contextmenuhelper_win.cpp Typically, the windows specific code must be separated from Qt based code. Gilles Created attachment 110575 [details]
Update patch to support native Open With under Windows.
This new version of the patch compile against git/master and add the feature to Showfoto.
Created attachment 110586 [details]
Update patch to support native Open With under Windows (version 3).
Fix broken compilation with UNICODE support
On digiKam windows, we have now an "Open With" option, but this one as no effect. There is nothing to see on debugview, no error, no warning... Gilles Caulier There is also some pointers here with native open with dialog under windows : https://docs.microsoft.com/en-us/windows/uwp/launch-resume/launch-the-default-app-for-a-file *** Bug 399285 has been marked as a duplicate of this bug. *** *** Bug 405174 has been marked as a duplicate of this bug. *** Git commit 6e7f92971d2fdbc611d10e141c835795d2e75623 by Gilles Caulier. Committed on 07/03/2019 at 12:41. Pushed by cgilles into branch 'master'. First try to handle OpenWith dialog under Windows M +63 -7 core/app/items/utils/contextmenuhelper.cpp M +16 -0 core/app/main/main.cpp M +16 -0 core/showfoto/main/main.cpp https://commits.kde.org/digikam/6e7f92971d2fdbc611d10e141c835795d2e75623 Maik, Under Windows 7, with DebugView, i never seen this debug trace : https://cgit.kde.org/digikam.git/tree/core/app/items/utils/contextmenuhelper.cpp#n350 ...when i activate "Open With" action from context menu. Can you confirm on your computer ? Gilles Git commit ae51ba537e7307d9d7598cf943f19ca99f5a400b by Maik Qualmann. Committed on 08/03/2019 at 22:17. Pushed by mqualmann into branch 'master'. fix empty item list M +2 -2 core/app/items/utils/contextmenuhelper.cpp https://commits.kde.org/digikam/ae51ba537e7307d9d7598cf943f19ca99f5a400b Git commit 01a20933a2c7c211f55c0591ffca06dfe0656c06 by Maik Qualmann. Committed on 08/03/2019 at 22:21. Pushed by mqualmann into branch 'master'. fix file not found error M +2 -2 core/app/items/utils/contextmenuhelper.cpp https://commits.kde.org/digikam/01a20933a2c7c211f55c0591ffca06dfe0656c06 There is now an error message that the file no program is assigned and you should assign a program in the control panel... Maik Ok, works in part, if an unknown file type is selected (PGF) appears the desired dialog. But not with a JPG file that is associated with Paint. Maik Git commit 63d778b4b4b3bca9bdfac4be2d2adf7f02f5aa17 by Maik Qualmann. Committed on 08/03/2019 at 23:17. Pushed by mqualmann into branch 'master'. this open with dialog now seems to work M +1 -1 core/app/items/utils/contextmenuhelper.cpp https://commits.kde.org/digikam/63d778b4b4b3bca9bdfac4be2d2adf7f02f5aa17 Git commit 4b55d48e5500feb59c2564ae6fc1e0672c77ff29 by Maik Qualmann. Committed on 09/03/2019 at 20:44. Pushed by mqualmann into branch 'master'. polish shell execute and fix compile warnings tested on Windows7 and Windows10 FIXED-IN: 6.1.0 M +2 -1 NEWS M +6 -8 core/app/items/utils/contextmenuhelper.cpp https://commits.kde.org/digikam/4b55d48e5500feb59c2564ae6fc1e0672c77ff29 |
Created attachment 105666 [details] Click-Right menu under windows - "open with" missing Under Linux I've the menu entry to open images (I use Photoflow). But under Windows this entry doesn't exist. I've verified that NEF and JPG files are set to be opened by photoflow.