Bug 379849

Hi Chris,

Could you provide detailed steps and attach some screenshots is better to reproduce the bug? I only use the simulator CDEmu http://www.leetcode.cn/2016/08/k3b.html#test so I can not reproduce it, thanks a lot!

Regards,
Leslie Zhai

Created attachment 105589 [details]
Disc Copy Dialog

The setting used in my copy (Note Copy mode is set to Clone)

Created attachment 105590 [details]
The file that are existing

The Files its going to try to write are here already

Hope this helps find this bug

Hi Chris,

Thanks for your screenshot!

But could you provide the screenshot for The overwrite prompt, I doubt it might be the bug about related dialog.

Regards,
Leslie Zhai

Yesterday i had upgraded to 17.04.1 release of k3b and this issue seams to be resolved as I don't get an overwrite prompt at all it just picks a new file name 
if the file exists

Hi Chris,

> it just picks a new file name if the file exists

is that ok? to fix your issue :)

Regards,
Leslie Zhai

It does fix the problem of the rip not starting, however I do think k3b should prompt if the target exists for clone opperations. This is what happens for non clone opperations and this behavior should be consistant throuh out the application.

After some further testing I think i have found the exact case where this is failing. 

if you copy a disc in clone mode with no disc label then copy another disc with no label. In this case instead of picking a file new file name it will use the default k3bimage.iso and k3bimage.iso.toc . in this case if those files exist when you try to copy the second disc the process will never start. if you try to copy the same non labeled disc twice it will just make a new image under a new name.

Hi Chris,

Sorry for my late response, I am doing my work assignment about L4 recently http://os.inf.tu-dresden.de/pipermail/l4-hackers/2017/ I will fix the bug in Thursday this week :)

Regards,
Leslie Zhai

Git commit 892df04090ae272860627026877cd2de353a90ca by Leslie Zhai.
Committed on 08/06/2017 at 02:41.
Pushed by lesliezhai into branch 'master'.

Check for m_tempDirSelectionWidget->tempPath() and
m_tempDirSelectionWidget-tempPath() + ".toc"

For example, if /tmp/k3b.iso and /tmp/k3b.iso.toc exist, then it
needs to ask user 'Do you want to overwrite XXX?' should
K3b::MediaCopyDialog automatically delete tmp files? I argue that
it is better to mv tmp files by user.

M  +3    -1    src/misc/k3bmediacopydialog.cpp

https://commits.kde.org/k3b/892df04090ae272860627026877cd2de353a90ca

Hi Chris,
 
> Check for m_tempDirSelectionWidget->tempPath() and
> m_tempDirSelectionWidget-tempPath() + ".toc"
> 
> For example, if /tmp/k3b.iso and /tmp/k3b.iso.toc exist, then it
> needs to ask user 'Do you want to overwrite XXX?' should
> K3b::MediaCopyDialog automatically delete tmp files? I argue that
> it is better to mv tmp files by user.

in your ~/.config/k3brc, there are:

[General Options]                                                                  
...                                                                  
Temp Dir=/tmp
...

so I argue that it is better to mv exist tmp files by user, but not by K3b::MediaCopyDialog, thoughts? thanks!

Regards,
Leslie Zhai

Im not sure of what your asking. If the file exsists the do you want to overwrite box does comeup . after you click yes the process of coping does not start.

Git commit 9bf5cdeef5803445ca7f67dd54ae694147e0fd53 by Leslie Zhai.
Committed on 09/06/2017 at 03:37.
Pushed by lesliezhai into branch 'master'.

Fix BurnProgressDialog delete wrongly issue.

M  +2    -6    src/misc/k3bmediacopydialog.cpp

https://commits.kde.org/k3b/9bf5cdeef5803445ca7f67dd54ae694147e0fd53

Hi Chris,
 
> Fix BurnProgressDialog delete wrongly issue.
> 
> M  +2    -6    src/misc/k3bmediacopydialog.cpp
> 
> https://commits.kde.org/k3b/9bf5cdeef5803445ca7f67dd54ae694147e0fd53

Please verify, thanks a lot!

Regards,
Leslie Zhai

I've Built and Tested this is working perfectly now. Both the .img and .img.toc ask if i want to overwrite and then the process starts. Marking as Fixed !

Sorry i had to reopen this, it now crashes after you close the copy dialog ..

Git commit 01d478f6dbbf97e358c02346fd14d111511f88be by Leslie Zhai.
Committed on 09/06/2017 at 14:50.
Pushed by lesliezhai into branch 'master'.

Fix segfault for K3b::MediaCopyDialog

M  +14   -2    src/misc/k3bmediacopydialog.cpp

https://commits.kde.org/k3b/01d478f6dbbf97e358c02346fd14d111511f88be

Hi Chris,

> Fix segfault for K3b::MediaCopyDialog
> 
> M  +14   -2    src/misc/k3bmediacopydialog.cpp
> 
> https://commits.kde.org/k3b/01d478f6dbbf97e358c02346fd14d111511f88be

Please verify it, thanks!

Regards,
Leslie Zhai

No longer crashes when i close the copy dialog :D  I will close it again.

Hi Chris,

> No longer crashes when i close the copy dialog :D  I will close it again.

Thanks for your test patiently!

Regards,
Leslie Zhai