| Summary: | [PATCH] Missing pselect syscall (OS X 10.11) | ||
|---|---|---|---|
| Product: | [Developer tools] valgrind | Reporter: | Louis Brunner <louis.brunner.fr> |
| Component: | general | Assignee: | Rhys Kidd <rhyskidd> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ivosh, louis.brunner.fr, rhyskidd, zerderr |
| Priority: | NOR | ||
| Version: | 3.13 SVN | ||
| Target Milestone: | --- | ||
| Platform: | macOS (DMG) | ||
| OS: | macOS | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 365327 | ||
| Attachments: |
Adds the pselect handler
Adds the pselect handler (Darwin specific) |
||
POSIX does not mandate pselect kernel interface; it mandates only pselect system (library) interface. Therefore placing pselect syscall wrapper in syswrap-generic. is not very fortunate. Have a look at other OSes and their kernel interfaces - Linux has pselect6, Solaris has no pselect at all (libc bases it directly on ppoll). Only *BSD seems to have the same kernel interface as OS X does. Created attachment 105563 [details]
Adds the pselect handler (Darwin specific)
Ivo,
My bad, thanks for the correction!
I moved it to Darwin instead of generic.
Based on xnu source this syscall #394 as pselect was added in OS X 10.11 (El Capitan). Thanks for the patch Louis. A version based upon it was committed as 55fe390. |
Created attachment 105473 [details] Adds the pselect handler Adds the pselect handler in the generic syscall file because it is defined by POSIX and the implementation is fairly basic (select with an extra check). It is only included by Darwin (Linux seems to have its own handler).