Bug 379593

Summary:	git master fails to build: plasma_version.h not found
Product:	[Frameworks and Libraries] kio-extras	Reporter:	Fabian Vogt <fabian>
Component:	default	Assignee:	Plasma Development Mailing List <plasma-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jjm, sitter
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kio-extras/6d47e158a4e20af0c365d9aac17a5c69553d9e5e	Version Fixed In:
Sentry Crash Report:

Description Fabian Vogt 2017-05-06 20:35:32 UTC

Using git master:

man/man2html.cpp:146:29: fatal error: plasma_version.h: No such file or directory
# include <plasma_version.h>

Most likely needs plasma-framework devel files to be installed, but cmake does not check for it.

Comment 1 Harald Sitter 2017-05-07 14:29:22 UTC

CCing Jonathan Marten as he has been getting rid of kdelibs4support which likely implicitly pulled in plasma-framework.

On a related note: CI is also read, albeit for different reasons.
https://build.kde.org/job/kio-extras%20master%20kf5-qt5/

Comment 2 Jonathan Marten 2017-05-07 15:57:55 UTC

CI (comment #1) should have been fixed by commit 6be8b06a to kio-extras.

I'll commit a further fix for the version numbering:  to avoid introducing an extra dependency it should be possible to just use the PROJECT_VERSION that is set in kio-extras' CMakeLists.txt.

Comment 3 Jonathan Marten 2017-05-07 20:02:31 UTC

Git commit 6d47e158a4e20af0c365d9aac17a5c69553d9e5e by Jonathan Marten.
Committed on 07/05/2017 at 19:59.
Pushed by marten into branch 'master'.

man ioslave: Do not depend on Plasma for version numbers

The version numbers are only used for display to the user in specially
formatted KDE man pages.  Take them from the version of the kio-extras
package.

M  +6    -0    config-runtime.h.cmake
M  +11   -8    man/man2html.cpp

https://commits.kde.org/kio-extras/6d47e158a4e20af0c365d9aac17a5c69553d9e5e