Bug 379564

Summary:	brush size slider is disabled when switching from smart patch tool
Product:	[Applications] krita	Reporter:	Scott Petrovic <scottpetrovic>
Component:	Tools	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	griffinvalley, halla, nicholaslapointe8, raghu, rjquiralte
Priority:	NOR
Version:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Solaris
Latest Commit:	https://commits.kde.org/krita/3d7bf514427e0e50e8368cc43da4cbfff977280a	Version Fixed In:
Sentry Crash Report:

Description Scott Petrovic 2017-05-05 18:58:11 UTC

steps to reproduce:

1. select the smart patch tool
2. select the freehand brush tool

expected: The brush size slider to be active
result: the brush size slider is disabled

Comment 1 Quiralta 2017-05-06 02:10:52 UTC

I can confirm it, but for me this happens as soon as I open Krita, the bar looks active but as soon as I touch the tablet (first stroke) regardless of the tool, the bar gets disabled. The Smart Patch Tool is the only one where the slider is active, thus I don't need to select it first to trigger the behavior as Scott's steps.

Side note, also the tooltip for this tool has some odd characters at the end of the name.

specs: master build, archlinux, plasma, nvidia.

Comment 2 Nicholas LaPointe 2017-05-17 20:14:20 UTC

The bug is caused by the following code from KisPaintopBox::slotToolChanged() added in commit ec5837d18ab54a678dcdefebd0d0613cb2d1ccb3 ("Healing brush tool"):
        if (flags & KisTool::FLAG_USES_CUSTOM_SIZE) {
            setWidgetState(ENABLE_SIZE | ENABLE_FLOW);
        } else {
            setWidgetState(DISABLE_SIZE | DISABLE_FLOW);
        }

The only tool setting this flag at the moment is the smart patch tool. (I also wonder if flow should be disabled here, unless smart patch uses it.)

Comment 3 Halla Rempt 2017-05-22 09:23:20 UTC

Should be fixed with   https://phabricator.kde.org/D5907

Comment 4 wolthera 2017-05-23 16:04:14 UTC

I am gonna close this then.

Comment 5 Raghavendra kamath 2017-05-30 04:00:51 UTC

Is this fix in the master? because I can reproduce it in master and I couldn't find the commit regarding this in the master

Comment 6 Allen Marshall 2017-05-31 19:02:20 UTC

Git commit 3d7bf514427e0e50e8368cc43da4cbfff977280a by Allen Marshall.
Committed on 31/05/2017 at 18:54.
Pushed by allenmarshall into branch 'master'.

Merge local branch 'bug-toolsize'
Differential Revision: https://phabricator.kde.org/D5907


https://commits.kde.org/krita/3d7bf514427e0e50e8368cc43da4cbfff977280a