Summary: | Can't select affine transition without crash. | ||
---|---|---|---|
Product: | [Applications] kdenlive | Reporter: | Joseph Rice <daviljoe193> |
Component: | Effects & Transitions | Assignee: | Vincent PINON <vpinon> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | french.ebook.lover, fritzibaby, jpbovee, linux4cyril, peron.nanou, pgkos.bugzilla, tore, ttguy1 |
Priority: | NOR | ||
Version: | git-master | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | attachment-11149-0.html |
Description
Joseph Rice
2017-04-27 05:27:02 UTC
I rolled back to version 16.12.3, and this doesn't happen on that version, so at least my project isn't going to be inaccessible in the mean time. Same here on Kdenlive 17.04 on Manjaro. Copy/paste an affine transition, try to move it, it crashes. Everytime. Same problem as bug 379520? Sounds exactly like my issue, annoying since it's possible to place the affine transition on the timeline without selecting it, but not possible to remove it, since every way to do so also arbitrarily requires selecting it, essentially "bricking" the project until you roll back the Kdenlive version. Also, thanks for the importance vote. Git commit 3ab863f0d58594802b53a36d0002d9415b9622ba by Nicolas Carion. Committed on 09/05/2017 at 15:35. Pushed by alcinos into branch 'Applications/17.04'. Fix init of geometryWidget M +3 -3 src/effectstack/widgets/geometrywidget.cpp https://commits.kde.org/kdenlive/3ab863f0d58594802b53a36d0002d9415b9622ba *** Bug 379520 has been marked as a duplicate of this bug. *** Should be fixed, tell me if you still run into issues regarding this. *** Bug 379586 has been marked as a duplicate of this bug. *** *** Bug 379138 has been marked as a duplicate of this bug. *** (In reply to alcinos from comment #8) Compiled the git version (17.07.70.r8463.6435a4ebd), and it still happens, but it crashes a bit more quickly? Definitely not fixed. Doing the same thing causes the same crash. I'm not 100% sure if I even installed the fixed version, all I know is that between a few hours ago and now, the git version changed, and I compiled and installed the newer version. Did you mean to reopen this issue? The state 'verified' would mean the fix has been verified to work. (In reply to Christoph Feck from comment #10) > Did you mean to reopen this issue? The state 'verified' would mean the fix > has been verified to work. I'm not really terribly familiar with Bugzilla, so I don't really know what to do at this point. The fix done by Alcinos didn't seem to fix anything, though as I mentioned before, I don't even know if I had the fixed version or not. Just noticed that the git version changed again, but the version number went down? It changed from 17.07.70.r8463.6435a4ebd to 17.03.70.r7974.a09d52c. I'm guessing this lower (but also newer) version is the "fixed" version I didn't download and compile. Will compile and install it to see if it fixes the issue. I'm normally this incompetent. Nope, not fixed. (In reply to Joseph Rice from comment #12) > Just noticed that the git version changed again, but the version number went > down? It changed from 17.07.70.r8463.6435a4ebd to 17.03.70.r7974.a09d52c. > I'm guessing this lower (but also newer) version is the "fixed" version I > didn't download and compile. Will compile and install it to see if it fixes > the issue. I'm normally this incompetent. As for the version number changing, it seems to just be a mistake on my end, since the package, after being compiled, still seems to be 17.07.70.r8463.6435a4ebd. Also, not sure what to change status to. It would be nice if someone could verify this: The crash always happens when the beginning (startpoint) of the affine transition is before a video clip (so there is no video clip present at the moment when the affine transition starts). My analysis shows that the problem probably is in the CustomTrackView::updateTimelineSelection(): timeline/customtrackview.cpp:823 call to getClipItemAtStart(m_dragItemInfo.startPos, m_dragItemInfo.track); returns null if the transition does not begin at exactly the same timepoint as a video clip, and therefore the frame size (p) remains zero, which will then cause a crash in geometrywidget.cpp:59: m_originalSize->setEnabled(false); will always crash, as m_originalSize is always null in that line. Calling getClipItemAtStart (in customtrackview.cpp:823) is conceptually wrong - a transition may begin when there is no clip. We would need something like "getFirstClipFollowingStart". Also, see the full backtrace with debugging symbols here: bug 379586. (In reply to pgkos.bugzilla from comment #15) > It would be nice if someone could verify this: > > The crash always happens when the beginning (startpoint) of the affine > transition is before a video clip (so there is no video clip present at the > moment when the affine transition starts). > In my case, I use the affine transition between 2 videos. So there is a video clip present at the "startpoint" (actually, there are even 2 videos). (In reply to Cyril from comment #16) > In my case, I use the affine transition between 2 videos. So there is a > video clip present at the "startpoint" (actually, there are even 2 videos). The alcinos' commit fixes the issue for me - I have just rebuilt the latest git 17.04 branch and everything works fine. Just make sure you do: git clone "git://anongit.kde.org/kdenlive.git" git checkout Applications/17.04 (In reply to pgkos.bugzilla from comment #17) > The alcinos' commit fixes the issue for me - I have just rebuilt the latest > git 17.04 branch and everything works fine. This was not clear to me, I was still referring to the original bug report. Now that the bug-fix should have propagated (it is on master and on the latest AppImage, but not 17.04.1 unfortunately), could you try and see if all the problems are gone ? (In reply to alcinos from comment #19) > Now that the bug-fix should have propagated (it is on master and on the > latest AppImage, but not 17.04.1 unfortunately), could you try and see if > all the problems are gone ? Using the AppImage, it works for me. Thanks you! Created attachment 105672 [details] attachment-11149-0.html Hi! Many thanks ! I'll try. with some care I succeeded to get out. Sure that fixing it will make it more confortable. Jean-Pierre ----- Mail original ----- De: "Cyril" <bugzilla_noreply@kde.org> À: jpbovee@free.fr Envoyé: Lundi 22 Mai 2017 13:29:44 Objet: [kdenlive] [Bug 379274] Can't select affine transition without crash. https://bugs.kde.org/show_bug.cgi?id=379274 --- Comment #20 from Cyril <linux4cyril@free.fr> --- (In reply to alcinos from comment #19) > Now that the bug-fix should have propagated (it is on master and on the > latest AppImage, but not 17.04.1 unfortunately), could you try and see if > all the problems are gone ? Using the AppImage, it works for me. Thanks you! I have a project where I can reproduce this issue in version 17.04.0. My experince is that if you try and select and move an affine transtion while the play head/carat is over the affine transition it crashes. But when I run appimage 17.04.1 the bug is gone. So I say this is fixed. |