Bug 379193

Summary: DDoSing discover/featured-5.9.json ocs/providers.xml
Product: [Applications] Discover Reporter: Jonathan Riddell <jr>
Component: discoverAssignee: Aleix Pol <aleixpol>
Status: RESOLVED FIXED    
Severity: normal CC: bcooksley, jr
Priority: NOR    
Version First Reported In: 5.9.4   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-desktop/3189f81aa6f38168f488ab2ffe810d717fcf6204 Version Fixed/Implemented In:
Sentry Crash Report:

Description Jonathan Riddell 2017-04-25 13:20:40 UTC 
<bcooksley> okay, Discover has a severe DOS bug then
<bcooksley> I see a pattern repeating over and over
<bcooksley> where the url /ocs/providers.xml is absolutely slammed very hard
<bcooksley> and I mean like 20 requests in a single second hard
<bcooksley> at the same time that IP also hits that discover featured url
<Riddell> https://autoconfig.kde.org/discover/featured-5.9.json is what is looks for
<bcooksley> yep, thats the vhost that gets hammered
<bcooksley> (it hits download.kde.org/ocs/providers.xml first though)
<bcooksley> is there any reason why it would want to fetch 20 or so copies of the OCS providers.xml file?
Comment 1 Christoph Feck 2017-04-27 11:12:57 UTC 
Is there some KDE/KIO network integration for QML? https requests should be cached.
Comment 2 Aleix Pol 2017-04-28 11:27:53 UTC 
Much better now that we have some kind of cache-age, the revision below should close the bug when it's in.

https://phabricator.kde.org/D5616
Comment 3 Aleix Pol 2017-04-28 12:59:22 UTC 
Git commit 3189f81aa6f38168f488ab2ffe810d717fcf6204 by Aleix Pol.
Committed on 28/04/2017 at 12:58.
Pushed by apol into branch 'master'.

Set up a cache for attica

Summary:
Reuses the same code we used to cache resources within Discover

Reviewers: #plasma, leinir

Reviewed By: leinir

Subscribers: jgrulich, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5616

M  +9    -0    attica-kde/kdeplugin/kdeplatformdependent.cpp

https://commits.kde.org/plasma-desktop/3189f81aa6f38168f488ab2ffe810d717fcf6204