| Summary: | kdegraphics/libs translations not found | ||
|---|---|---|---|
| Product: | [Developer tools] releaseme | Reporter: | Jonathan Riddell <jr> |
| Component: | general | Assignee: | Harald Sitter <sitter> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/releaseme/309af97921a89423941b5d6a5cefaed4e534c1cb | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Jonathan Riddell
2017-04-24 13:09:03 UTC
Git commit 309af97921a89423941b5d6a5cefaed4e534c1cb by Harald Sitter.
Committed on 25/04/2017 at 12:42.
Pushed by sitter into branch 'master'.
reduce drop limit after removing a leading kde/ part
The general assumption is that path.split.pop.join('-') will be the
i18n_path. e.g. playground/utils becomes playground-utils and
playground/utils/libs becomes also playground-utils. To that end we drop
parts until we have <= 2 to join. This was going wrong with nested projects
inside kde/* projects as we drop the first kde/ part.
So kde/kdegraphics/libs would be [kde,kdegraphics,libs] then we drop the
kde to get [kdegraphics,libs] and now no longer drop parts treating it
like playground, when really it shouldn't be as effectively our
requirements are different. Technically we want [kde,kdegraphics,libs] to
be popped until only 2 are left, we can't do that because dropping kde
is sort of a pre condition, otherwise we'll have to do some mind bending
to prevent empty paths etc.
M +49 -14 lib/releaseme/project.rb
M +48 -0 test/data/kde_projects.xml
M +11 -1 test/test_project.rb
https://commits.kde.org/releaseme/309af97921a89423941b5d6a5cefaed4e534c1cb
Git commit bce4b5f833cbbaba27de4fe6c27cf2758f4af4a8 by Harald Sitter. Committed on 07/06/2017 at 11:34. Pushed by sitter into branch 'master'. add explicit regression testing previously in releaseme Related: bug 379164 M +8 -0 models/i18n_test.go https://commits.kde.org/sysadmin/projects-api/bce4b5f833cbbaba27de4fe6c27cf2758f4af4a8 |