| Summary: | Dolphin crash when closing tab | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | oysstu <oysstu> |
| Component: | general | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | 2020cmitchell, archer, elvis.angelaccio, jmeloc, martin.sandsmark, simokj.makkonen, support |
| Priority: | NOR | Keywords: | drkonqi, regression |
| Version: | 17.04.0 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=380032 | ||
| Latest Commit: | https://commits.kde.org/dolphin/43da84eefc7d68ce86cda2d353216dbe7552fc2c | Version Fixed In: | 17.04.2 |
| Sentry Crash Report: | |||
|
Description
oysstu
2017-04-23 18:41:07 UTC
*** Bug 379726 has been marked as a duplicate of this bug. *** *** Bug 379913 has been marked as a duplicate of this bug. *** This is what happens: 1. The searchbox of the first tab gets disactivated (as side effect of disactivating its container). 2. Second tab gets closed, we call removeTab(1) in the tab widget. 3. The searchbox of the first tab gets a FocusIn event and calls setActive(true). 4. Since it was disactivated, it emits activated() and this results in the activeViewChanged() signal which causes the crash, because the currentIndex() of the tab page is still 1 but widget(1) has already been invalidated. Git commit 43da84eefc7d68ce86cda2d353216dbe7552fc2c by Anthony Fieroni. Committed on 22/05/2017 at 17:35. Pushed by anthonyfieroni into branch 'Applications/17.04'. Correct searchbox, split view transitions between tabs Differential Revision: https://phabricator.kde.org/D5864 Related: bug 380032 FIXED-IN: 17.04.2 Signed-off-by: Anthony Fieroni <bvbfan@abv.bg> M +22 -7 src/dolphintabpage.cpp M +7 -0 src/dolphintabpage.h M +8 -8 src/dolphintabwidget.cpp M +7 -2 src/search/dolphinsearchbox.cpp https://commits.kde.org/dolphin/43da84eefc7d68ce86cda2d353216dbe7552fc2c *** Bug 380234 has been marked as a duplicate of this bug. *** Git commit 1faef1c92d168e8f22d91d968c6fe29e70674699 by Elvis Angelaccio. Committed on 27/05/2017 at 08:28. Pushed by elvisangelaccio into branch 'master'. Introduce DolphinMainWindowTest For now it contains a test case for the crash in bug #379135 Reviewers: emmanuelp, dfaure Differential Revision: https://phabricator.kde.org/D5936 M +1 -0 src/dolphinmainwindow.cpp M +5 -0 src/tests/CMakeLists.txt A +69 -0 src/tests/dolphinmainwindowtest.cpp [License: GPL (v2+)] https://commits.kde.org/dolphin/1faef1c92d168e8f22d91d968c6fe29e70674699 *** Bug 380891 has been marked as a duplicate of this bug. *** *** Bug 393327 has been marked as a duplicate of this bug. *** |