| Summary: | kaccounts_add_services depends on intltools | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] KAccounts | Reporter: | Olivier Churlaud <olivier> |
| Component: | general | Assignee: | Telepathy Bugs <kde-telepathy-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | arojas, elvis.angelaccio |
| Priority: | NOR | ||
| Version: | git-latest | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kaccounts-integration/3b3842d1576076de8652b9d2744e6785014bbc5a | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Olivier Churlaud
2017-04-18 19:51:22 UTC
I was recently hit by this with kio-gdrive. The problem is that intltools is a build-time only dependency, kaccounts-integration is perfectly functional without intltools installed at runtime. So the only solution is that every project that uses kaccounts_add_service adds a find_package(Intltools) call (which is annoying because intltool is not cmake-friendly, you need to add a FindIntltool.cmake in your project). A simple error message if the intltool-merge command isn't found would help a lot. kio-gdrive was the second time (after purpose) that I had to go digging into the source code to figure out why the build was failing. Yeah we can probably do that. Git commit 3b3842d1576076de8652b9d2744e6785014bbc5a by Elvis Angelaccio. Committed on 06/07/2017 at 21:23. Pushed by elvisangelaccio into branch 'Applications/17.04'. Add error message if intltool-merge is not found Users of the kaccounts_add_* macros are supposed to do a find_package(Intltool REQUIRED), but if they don't the build fails with a rather obscure message (`make install` fails because the service or provider file was not generated). This error message will at least make the life of packagers a bit easier. Differential Revision: https://phabricator.kde.org/D6114 M +8 -0 src/lib/KAccountsMacros.cmake https://commits.kde.org/kaccounts-integration/3b3842d1576076de8652b9d2744e6785014bbc5a |