| Summary: | [PATCH] Incorrect termination of \iffalse comment for latex highlight | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Andrea <andrea.turrini> |
| Component: | syntax | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | Git | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/syntax-highlighting/4a3572b899a0796118f610252e0951b36d278e07 | Version Fixed/Implemented In: | KDE Frameworks 5.34 |
| Sentry Crash Report: | |||
|
Description
Andrea
2017-04-06 04:58:52 UTC
Could you try WordDetect instead of a regexp? This is faster and should do exactly what you want, see: https://docs.kde.org/stable5/en/applications/katepart/highlight.html WordDetect indeed produces the expected highlighting, with the code: <context name="Multiline Comment" attribute="Comment" lineEndContext="#stay"> <WordDetect String="\fi" attribute="Comment" context="#pop"/> <WordDetect String="\else" attribute="Comment" context="#pop"/> </context> Dominik, do you need a review request, or can we commit the change without further review? As is, but the unit test needs to be adapted. Will do asap, sorry... Git commit 4a3572b899a0796118f610252e0951b36d278e07 by Dominik Haumann. Committed on 22/04/2017 at 14:00. Pushed by dhaumann into branch 'master'. LaTeX: Fix Incorrect termination of \iffalse comments FIXED-IN: KDE Frameworks 5.34 M +5 -1 autotests/html/highlight.tex.html M +5 -1 autotests/input/highlight.tex M +5 -1 autotests/reference/highlight.tex.ref M +8 -8 data/syntax/latex.xml https://commits.kde.org/syntax-highlighting/4a3572b899a0796118f610252e0951b36d278e07 |