Bug 378447

Summary:	Rename an item and click somewhere else discards changes
Product:	[Plasma] plasmashell	Reporter:	Gregor Mi <codestruct>
Component:	Desktop icons & Folder View widget	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.9.4
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-desktop/45bea58f9bfeedcc06ec8ed086215287c2737155	Version Fixed/Implemented In:
Sentry Crash Report:

Description Gregor Mi 2017-04-04 22:00:02 UTC

ACTUAL:
If I press F2 to rename a file in the folder view and click somewhere else then the changes I made are silently discarded. If I press ENTER then the changes are saved correctly.

EXPECTED:
If the edit operation ends the changes the user made should be either saved or there should be a message that asks if it is ok to discard the changes.

Comment 1 Kai Uwe Broulik 2017-04-05 08:47:21 UTC

Oh, right, I was thinking the wrong way. Escape should cancel it but Return and pressing outside should accept.

Comment 2 Kai Uwe Broulik 2017-04-05 10:27:50 UTC

Git commit 45bea58f9bfeedcc06ec8ed086215287c2737155 by Kai Uwe Broulik.
Committed on 05/04/2017 at 10:27.
Pushed by broulik into branch 'master'.

[Folder View] Rename on clicking outside

When renaming a file and clicking elsewhere, actually rename instead of canceling. This is what Dolphin and other file managers do.
When pressing Escape, closing the popup, or starting to scroll, the rename operation is cancelled as before.

Differential Revision: https://phabricator.kde.org/D5305

M  +9    -4    containments/desktop/package/contents/ui/FolderView.qml

https://commits.kde.org/plasma-desktop/45bea58f9bfeedcc06ec8ed086215287c2737155