Bug 378254

Summary: Panel doesn't auto-hide if closing an alert window without selecting it first
Product: [Plasma] plasmashell Reporter: Mircea Kitsune <sonichedgehog_hyperblast00>
Component: Task Manager and Icons-Only Task Manager widgetsAssignee: Eike Hein <hein>
Status: RESOLVED FIXED    
Severity: minor CC: hein, notmart, plasma-bugs-null, sonichedgehog_hyperblast00
Priority: NOR    
Version First Reported In: 5.9.4   
Target Milestone: 1.0   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/plasma-workspace/628593db4c65560ace95759ffca5ce0920de621e Version Fixed/Implemented In:
Sentry Crash Report:

Description Mircea Kitsune 2017-03-29 22:03:00 UTC 
If a panel containing the task manager has auto-hide enabled, an alert window pops up, but the window is closed before it is selected... the panel will permanently remain visible and no longer hide, until you change desktops or preform other actions that reset it. Reproduction steps:

1 - Have a panel with Task Manager widget on it.
2 - In the settings of your panel enable "Auto Hide", so the panel is hidden and only shows when you place the pointer at the edge of the screen.
3 - Make a window present in the task manager generate an alert. With the default Breeze theme, you should see the normally blue underline turn orange. While this status is present, the taskbar doesn't auto-hide any more.
4 - Right click the task manager entry of the window and select "Close".

Result: The window is closed, but the panel doesn't notice its disappearance. Plasma still thinks an alert window is present, and refuses to auto hide the panel any more.

Additional: This is just partly related to the bug in cause, but it might be a good idea if alert windows didn't inhibit auto-hide altogether. I find the addition of this functionality an annoyance, which doesn't seem to help in any way either: Whenever a window generates an alert following a new event by its application, the panel suddenly pops up and covers a portion of the screen, often forcing me to select the window and make the alert status go away in order to click on or see things that the panel was covering.
Comment 1 Eike Hein 2017-03-30 11:13:01 UTC 
Guessing this is a panel containment bug, last time I debugged this the Task Manager applet itself was managing its attentions status correctly.
Comment 2 Marco Martin 2017-03-30 12:42:37 UTC 
I can confirm that in the exact scenario described, the task manager does not set a new status.
you have to close the window *without* selecting it beforehand for it to happen
Comment 3 Eike Hein 2017-03-31 09:32:04 UTC 
Yep, I was able to reproduce it now and it's indeed in libtaskmanager. Working up a fix.
Comment 4 Eike Hein 2017-03-31 10:33:17 UTC 
Git commit 628593db4c65560ace95759ffca5ce0920de621e by Eike Hein.
Committed on 31/03/2017 at 10:21.
Pushed by hein into branch 'Plasma/5.8'.

Fix TasksModel.anyTaskDemandsAttention not updating on window closure.

Summary:
Previously we updated the prop after checking for
AbstractTasksModel::IsDemandingAttention on window closure, but
as the window is gone, we can't actually get state for it anymore,
so we always need to update.

To make up for it, this patch also optimizes the prop updates to occur
only once per insert/remove batch - this is a bit academic because
the source models currently only insert single rows at a time, but
it's good hygiene.

Reviewers: #plasma, mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D5261

M  +14   -5    libtaskmanager/tasksmodel.cpp

https://commits.kde.org/plasma-workspace/628593db4c65560ace95759ffca5ce0920de621e