Summary: | Findings from code review | ||
---|---|---|---|
Product: | [Frameworks and Libraries] Akonadi | Reporter: | Steve <sgrubb> |
Component: | server | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | rdieter |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/akonadi/92c529c2cae9f9661b938fbbbe84a1fa180c832f | Version Fixed In: | 17.04 |
Description
Steve
2017-03-21 19:33:51 UTC
Git commit 92c529c2cae9f9661b938fbbbe84a1fa180c832f by Daniel Vrátil. Committed on 22/03/2017 at 00:27. Pushed by dvratil into branch 'Applications/17.04'. Fix missing break/return statements Thanks to Steve Grubb for pointing those out. FIXED-IN: 17.04 M +1 -0 src/core/changerecorder_p.cpp M +0 -2 src/private/protocol.cpp M +2 -0 src/server/handler.cpp https://commits.kde.org/akonadi/92c529c2cae9f9661b938fbbbe84a1fa180c832f Thanks for the review! The leaked FDs are false positives, as the FD is passed into QLocalSocket which then takes ownership and ensures they are freed when the QLocalSocket is destroyed. The "identical branches" warnings are from a generated code (code generated by Qt during compilation), so nothing I can fix easily. I fixed the missing return, missing break, and double return issues. Thanks again! |