| Summary: | Background for title clip contains title clip itself if cursor is over that title clip [video demo included] | ||
|---|---|---|---|
| Product: | [Applications] kdenlive | Reporter: | Andrew Shark <ashark> |
| Component: | Rendering & Export | Assignee: | Jean-Baptiste Mardelle <jb> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | git-master | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| URL: | https://youtu.be/n8AmeunCnNw | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Andrew Shark
2017-03-19 15:05:22 UTC
Yes, I have also often been annoyed by that issue, but never took time to try to fix it. Thanks for your report, I will try to work on it in the next days Here is my exploration path:
1) "Show background" sting is contained in titlewidget_ui.ui. Name of checkbox widget is "displayBg".
2) "displayBg" is mentioned in titlewidget.cpp on line 229:
connect(displayBg, &QCheckBox::stateChanged, this, &TitleWidget::displayBackgroundFrame);
and there is TitleWidget::displayBackgroundFrame() method.
3) TitleWidget::displayBackgroundFrame() is defined in the same file on line 840. It checks if checkbox is activated and if yes,
emit signal requestBackgroundFrame(true);
Also this file contains
void TitleWidget::slotGotBackground(const QImage &img)(const QImage &img)
{
QRectF r = m_frameBorder->sceneBoundingRect();
m_frameImage->setPixmap(QPixmap::fromImage(img.scaled(r.width() / 2, r.height() / 2)));
emit requestBackgroundFrame(false);
}
As you can see, it already gets image as a parameter.
So we should find where it prepares image and I think temporary disable title clip before getting it.
But I could not find place where slotGotBackground(const QImage &img) is called from.
4) Perhaps bin.cpp is a place where title editing is done (line 3393 says "TODO: move title editing into a better place..."). File contains the following:
connect(&dia_ui, &TitleWidget::requestBackgroundFrame, pCore->monitorManager()->projectMonitor(), &Monitor::slotGetCurrentImage);
Git commit 8e054c9a5205650ffd05d1f5725ff3a39290ab54 by Jean-Baptiste Mardelle. Committed on 19/03/2017 at 20:04. Pushed by mardelle into branch 'master'. Hide currently edited title clip when requesting background in title widget M +6 -3 src/bin/bin.cpp M +5 -2 src/bin/bin.h M +5 -1 src/monitor/glwidget.cpp M +1 -0 src/monitor/glwidget.h M +2 -2 src/monitor/monitor.cpp M +0 -2 src/monitor/monitormanager.cpp M +9 -0 src/timeline/timeline.cpp M +4 -0 src/timeline/timeline.h M +36 -0 src/timeline/track.cpp M +4 -0 src/timeline/track.h M +8 -6 src/titler/titlewidget.cpp M +17 -11 src/titler/titlewidget.h https://commits.kde.org/kdenlive/8e054c9a5205650ffd05d1f5725ff3a39290ab54 It works! Thank you very much, Mardelle =) |