| Summary: | Wrong reppresentation of arrays in the variable manager | ||
|---|---|---|---|
| Product: | [Applications] cantor | Reporter: | Alexander Semke <alexander.semke> |
| Component: | julia-backend | Assignee: | Ivan Lakhtanov <ivan.lakhtanov> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | filipe |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/cantor/8c7a0c37f0c7e7deb9f035339d0aecb2f5a819e4 | Version Fixed/Implemented In: | 18.04.2 |
| Sentry Crash Report: | |||
|
Description
Alexander Semke
2017-03-18 14:15:38 UTC
By the moment we are using 'show(var)' to get string to show in variable manager. So there is no special logic on the side of the Cantor backend for this. Can you specify exactly what info you wait from variable manager and why presence of array type looks redundant for you? To be more consistent with the other backends, I'd only expect here to see the values only without any data types (["a1","a2"] and not ASIIString["a1","a2"], etc.). For integer arrays in Julia this is already the case. Create an array either via a=[1,2,3] or via a=Array{Int64}(3) and check the results in the variable manager - you won't see there any "Int64".
So, there are mainly two reasons
1. we want to provide consistent behavior in the variable manager across different backends and also to stay consistent within Julia
2. for the integration in LabPlot (https://labplot.kde.org/2016/07/23/labplot-2-3-0-released/) we don't expect any data types, neither. We look only for the position of the brackets, strip them away, convert the remaining string to the vector of doubles and plot the values. In LabPlot we'd need now to also strip away all those data types like Int64, etc. I propose to do this directly in Cantor in order to provide more consistency as described in the first point.
Git commit 4facde26645b5ac777883de38a5dfc96487cc753 by Nikita Sirgienko. Committed on 02/06/2018 at 21:04. Pushed by sirgienko into branch 'master'. Make Julia variables format in variables model more consistent with the other backends FIXED-IN: 18.04.2 Differential Revision: https://phabricator.kde.org/D13290 M +6 -1 src/backends/julia/juliasession.cpp M +2 -0 src/backends/julia/juliasession.h https://commits.kde.org/cantor/4facde26645b5ac777883de38a5dfc96487cc753 Git commit 8c7a0c37f0c7e7deb9f035339d0aecb2f5a819e4 by Alexander Semke, on behalf of Nikita Sirgienko. Committed on 03/06/2018 at 08:29. Pushed by asemke into branch 'Applications/18.04'. Make Julia variables format in variables model more consistent with the other backends FIXED-IN: 18.04.2 Differential Revision: https://phabricator.kde.org/D13290 M +6 -1 src/backends/julia/juliasession.cpp M +2 -0 src/backends/julia/juliasession.h https://commits.kde.org/cantor/8c7a0c37f0c7e7deb9f035339d0aecb2f5a819e4 |