Bug 377614

Summary: Crash when moving larger quantities of animation frames
Product: [Applications] krita Reporter: Filip <filip>
Component: AnimationAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: crash CC: dimula73, filip, halla
Priority: NOR    
Version First Reported In: 3.1.2   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Crash report 2017-03-14

Description Filip 2017-03-14 14:40:31 UTC
Created attachment 104558 [details]
Crash report 2017-03-14

When I move large quantities of animation frames in the animation window, krita crashes every single time. It only happens when I move larger quantities like 20+ frames. Crash report backtrace attached, KDE Paste link: https://goo.gl/He70Jw

Windows 10 64-bit - 8GB RAM
Comment 1 Halla Rempt 2017-03-14 14:45:17 UTC
Thanks for your report!
Comment 2 Halla Rempt 2017-03-14 14:53:22 UTC
I could reproduce the crash by reducing memory allocation for Krita (not sure whether that's necessary) and creating lots of frames with ctrl-copy. It didn't crash when running under gdb, which suggests it's not a memory but a timing issue.
Comment 3 Dmitry Kazakov 2017-04-07 12:06:42 UTC
The crash seem to happen because the source or destination layers do not exist. Or, exists, bit expunged from the timeline due to some combination of "show in timeline" option
Comment 4 Dmitry Kazakov 2017-04-07 12:10:15 UTC
Yes, I can reproduce the problem by dropping frames into the active layer that doesn't have "show in timeline" option set and *very quickly* pressing pgdown.
Comment 5 Dmitry Kazakov 2017-04-07 12:38:41 UTC
Git commit b0aa6b3cd990ed276bfcacedbba97a5bd0efb154 by Dmitry Kazakov.
Committed on 07/04/2017 at 12:38.
Pushed by dkazakov into branch 'master'.

Fix a crash when the layer gets changed too quickly during frames move
Ref T5753

M  +6    -1    plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/b0aa6b3cd990ed276bfcacedbba97a5bd0efb154
Comment 6 Filip 2017-04-13 12:43:58 UTC
Dmitry, can you reproduce the crash without changing layer during frame move? My problem is directed towards a crash that happens when you move larger quantities of frames (20+) in the animation docker. Changing active layer shouldn't be necessary to induce the crash.
Comment 7 Dmitry Kazakov 2017-04-17 12:03:49 UTC
Git commit c836a1d8f55f689a979ebd1fc9ff3e2098f30cae by Dmitry Kazakov.
Committed on 17/04/2017 at 11:37.
Pushed by dkazakov into branch 'krita/3.1'.

Fix a crash when the layer gets changed too quickly during frames move
Ref T5753

M  +6    -1    plugins/dockers/animation/timeline_frames_model.cpp

https://commits.kde.org/krita/c836a1d8f55f689a979ebd1fc9ff3e2098f30cae