Bug 377552

Summary:	Pressing navigating layers in rename mode (F2) deselects the layer name
Product:	[Applications] krita	Reporter:	Nathan GDquest <nathan>
Component:	Layer Stack	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED WORKSFORME
Severity:	minor	CC:	freebox64, halla
Priority:	NOR	Keywords:	triaged
Version First Reported In:	3.1.2
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	(Video example) Layer name gets deselected when jumping to the first child in the group

Description Nathan GDquest 2017-03-13 07:26:37 UTC

When you use F2 to rename multiple layers in a row (using tab or Pg down and F2 again), the layer name always gets deselected.
The ability to rename layers with F2 is a great feature to export the individual layers that make up a Krita document, be it for Spriter, Blender or anything else. But in the current state, you always have to press Ctrl A or Ctrl Shift Left arrow to select the layer name, which isn't very convenient.

Naming layers is part of a game artist's daily routine, and here's how I'd like to use the tool:
1. Enter isolate layer mode
2. Press F2 and rename the first layers
3. Press tab, name the layer, rinse and repeat

Steps for the "bug":
1. In a document with multiple layers
2. Press F2 to rename the currently selected layer
3. Press Tab or Shift Tab to move to the next/previous layer
4. After a short delay, the layer name gets deselected and the typing cursor is placed at the end of the layer name

Comment 1 mvowada 2017-03-13 09:40:29 UTC

Created attachment 104535 [details]
(Video example)

(With Krita 3.1.2 on Ubuntu 14.04 Unity 7.2.6)

Hi, I agree with your suggestion to improve the renaming layers process.
Though, for some reason, it seems I can't reproduce the "text deselect" problem on my system (video).

Also, the "TAB" key doesn't skip through layers here, instead it enters full-screen mode. While "Shift + TAB" works well.

(Wondering if Bug 365739 can be somehow related)

Comment 2 mvowada 2017-03-13 09:46:08 UTC

(In reply to mvowada from comment #1)
> it enters full-screen mode

Sorry, I meant "Canvas Only" :)

Comment 3 Nathan GDquest 2017-03-13 12:22:24 UTC

Created attachment 104538 [details]
Layer name gets deselected when jumping to the first child in the group

Comment 4 Nathan GDquest 2017-03-13 12:25:00 UTC

After running tests on new documents, it seems it only happens in some cases. When you jump from a group to its first child, it seems to always deselect the layer name.

Comment 5 mvowada 2017-03-13 15:12:28 UTC

I apologize, I just realized I was responding to a Windows user.

Comment 6 Halla Rempt 2017-03-14 09:42:11 UTC

There is a generic problem that global shortcuts aren't overridden by dockers. If a widget in the docker has focus, a global shortcut still overrides the normal behaviour of widgets in a dialog. However, if you use ctrl-tab and shift-tab to move between the layers, the rename field keeps focus. Is that an acceptable workaround?

Comment 7 Nathan GDquest 2017-03-14 11:52:52 UTC

That works for the full canvas mode. However the bug where the layer name gets deselected when you Tab from a group to its child remains.
By the way I can confirm that this only happens when you tab from a group/layer to its first child (be it a paint layer, a mask...).

(In reply to Boudewijn Rempt from comment #6)
> Is that an acceptable workaround?

Comment 8 Andrew Crouthamel 2018-09-28 02:40:13 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 9 Andrew Crouthamel 2018-10-28 03:34:29 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!