Bug 377510

Summary:	Dolphin's "Open path" context menu items (in the search view) should pre-select the file
Product:	[Applications] dolphin	Reporter:	Roman <bugworm>
Component:	search	Assignee:	Dolphin Bug Assignee <dolphin-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	bugseforuns, nate
Priority:	NOR
Version First Reported In:	16.12.2
Target Milestone:	---
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/dolphin/9536d1170a9ffa787b6a9809b2600c669d60d498	Version Fixed/Implemented In:
Sentry Crash Report:

Description Roman 2017-03-11 23:46:33 UTC

When you open files on dolphin through krunner/firefox/probably other apps, it open up folder and select file what we try to open. It will be nice if "Open path" option will follow the same logic, you really don't need just open the folder if you search a file in most cases, you need to open it with selected file you search. Also it will be nice to add "Open path in other view" when using split view mode

Comment 1 Nate Graham 2017-09-03 03:03:14 UTC

Hi Roman,
It's a bit hard to understand what you're asking for. Can you clarify? Also please try to stick to one bug/request per bugzilla ticket.

Comment 2 Roman 2017-09-03 06:39:26 UTC

https://youtu.be/_Zidrwc8p8k
This should clarify

Comment 3 Nate Graham 2017-09-03 13:31:10 UTC

Thanks, I understand now. Re-titling.

Basically the request is to have the file selected when its parent folder is revealed via the "Open path" context menu item.

Comment 4 Nate Graham 2018-03-26 00:24:17 UTC

Submitted a patch for this: https://phabricator.kde.org/D11703

Comment 5 Nate Graham 2018-04-09 23:08:18 UTC

Git commit 9536d1170a9ffa787b6a9809b2600c669d60d498 by Nathaniel Graham.
Committed on 09/04/2018 at 23:02.
Pushed by ngraham into branch 'master'.

Select and scroll to the file for "Open path" and "Open Path in New Window" operations

Summary:
After performing a search and using  the "Open path" or "Open Path in New Window"  present in the context menu, make sure the file is selected and visible in the resulting view.

Cannot implement the same fix for "Open Path in New Tab" because of a limitation in how the contents of inactive tabs are rendered; will need to fix that separately in another patch.

Test Plan: Search for an item, and choose {nav Open Path} or {nav Open path in new window}

Reviewers: #dolphin, elvisangelaccio

Reviewed By: #dolphin, elvisangelaccio

Subscribers: elvisangelaccio, broulik

Differential Revision: https://phabricator.kde.org/D11703

M  +3    -1    src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/9536d1170a9ffa787b6a9809b2600c669d60d498