Bug 377367

Summary: Editing of a Oracle database configuration file "tnsnames.ora" causes every used text editor to hang if Krita shell extension is installed
Product: [Applications] krita Reporter: Erwin Lackner <erwin.lackner>
Component: GeneralAssignee: Alvin Wong <alvin>
Status: RESOLVED FIXED    
Severity: crash CC: alvin, halla
Priority: NOR    
Version: 3.1.2   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
URL: https://github.com/alvinhochun/KritaShellExtension/issues/13
Latest Commit: Version Fixed In:
Attachments: Oracle database configuration file

Description Erwin Lackner 2017-03-08 07:45:09 UTC
Created attachment 104447 [details]
Oracle database configuration file

Bug: 
Editing of a Oracle database configuration file "tnsnames.ora" causes every used text editor to hang if Krita shell extension is installed.

How to reproduce:
* Make sure that Krita is installed (with shell extension!!)
* Open file tnsnames.ora with text editor (eg. notepad, notpad++)
* Change file that save button is enabled
* Press button save
* Now editor hangs (caption bar shows message "No response")
* Using NtHandle 4.1 (SysInternals/Mark Russinovich) shows that several filehandles from explorer are on file
		C:\Software\Nthandle>handle c:\oracle\tnsnames.ora

		Nthandle v4.1 - Handle viewer
		Copyright (C) 1997-2016 Mark Russinovich
		Sysinternals - www.sysinternals.com

		explorer.exe       pid: 4264   type: File          2EFC: C:\oracle\tnsnames.ora
		explorer.exe       pid: 4264   type: File          31EC: C:\oracle\tnsnames.ora
		explorer.exe       pid: 4264   type: File          3978: C:\oracle\tnsnames.ora
		.... 15 more with same pid


Assumption:
* Shell extension causes this problem, because without installing it problem doesn't occure.

Environment
===========
OS: Windows 10 Enterprise x64
Krita: 3.1.2.1 x64 
TnsNames.ora -> see attachment
Comment 1 Halla Rempt 2017-03-14 09:25:04 UTC
I guess explorer runs the shell extension which doesn't really check the file format before trying to open the ora file as a zip file. I've pinged the author of the shell extension.
Comment 2 Alvin Wong 2017-04-29 19:00:36 UTC
Though I can only get prompts saying the file is locked, I guess it's the same issue. I'll be looking at it in a few days.
Comment 3 Alvin Wong 2017-04-30 08:59:21 UTC
It should be fixed in v1.2.3 of the shell extension:
https://github.com/alvinhochun/KritaShellExtension/releases/tag/v1.2.3

@Erwin Lackner
If you see this before a new release of Krita is out, would you mind testing it by installing `kritashellex-1.2.3.0-setup.exe` from the above link? It can be installed alongside with Krita itself.