Summary: | plasma5 crash after detaching secondary screen | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | edgardo arrieta <edgardowilliam> |
Component: | general | Assignee: | David Edmundson <kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | bhush94, notmart, ogldelphi, plasma-bugs, taitos.fci |
Priority: | NOR | Keywords: | drkonqi |
Version: | 5.8.3 | ||
Target Milestone: | 1.0 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/plasma-workspace/bcb6b86d3ab8bd196877473af343b72c53e4f932 | Version Fixed In: |
Description
edgardo arrieta
2017-03-06 17:17:53 UTC
line numbers don't seem to correspond exactly with the 5.8.3 tag, btw, the crash is probably at line 1792 if (m_desktopViewforId.value(id)->containment() == containment && containment->activity() == m_activityController->currentActivity()) { like screenForContainment was called before the deleted desktopview was removed fro mthe pool in the notifications applet, connect(KWindowSystem::self(), &KWindowSystem::workAreaChanged, this, &NotificationsApplet::onScreenChanges); seems to trigger onScreenChanges, then containment()->corona()->availableScreenRect(containment()->screen()); in the middle of the way between view deletion and removal from the list possible solution: https://phabricator.kde.org/D4991 Git commit bcb6b86d3ab8bd196877473af343b72c53e4f932 by Marco Martin. Committed on 10/03/2017 at 11:16. Pushed by mart into branch 'Plasma/5.8'. try proper order of corona()->availableScreenRect() Summary: connect to Plasma::Corona::availableScreenRectChanged instead of using kscreen, this way we should be more sure that signal is emitted when it's safe to call corona()->availableScreenRect() as the change of rect may happen after a screen removal, so may mean accessing a desktop view while being deleted Test Plan: notifications still pop up in the proper place, couldn't reproduce the crash neither before nor after tough Reviewers: #plasma, davidedmundson Reviewed By: #plasma, davidedmundson Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4991 M +3 -4 applets/notifications/lib/notificationsapplet.cpp M +1 -1 shell/shellcorona.cpp https://commits.kde.org/plasma-workspace/bcb6b86d3ab8bd196877473af343b72c53e4f932 *** Bug 378151 has been marked as a duplicate of this bug. *** *** Bug 378508 has been marked as a duplicate of this bug. *** |