Bug 376687

Summary:	GPS tagging usability of bookmarks
Product:	[Applications] digikam	Reporter:	Jens <jens-bugs.kde.org>
Component:	Geolocation-Bookmarks	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	laurakittyinka
Priority:	NOR
Version:	5.5.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b	Version Fixed In:	5.6.0
Sentry Crash Report:

Description Jens 2017-02-19 21:45:26 UTC

I'm a little confused how to use the bookmarks feature in the Geotagging editor.

- You can create bookmarks in the map (using the context menu) and display them.

But:

- Bookmarks created on the map are gone when you restart Digikam.
  (Is this because of the Appimage concept which uses a temp mount?)
- Bookmarks created on the map cannot be used to assign a location to the images below. The lists seem to be completely separate.

What is the usage concept here? Or is this actually buggy?

Thank you :)

Comment 1 Barbara Scheffner 2017-02-20 00:10:49 UTC

To get an idea of the situation regarding these bookmarks see 
https://bugs.kde.org/show_bug.cgi?id=376074 !
Maybe this bug should be marked a duplicate but I'm not sure and also don't know how to do that.

Comment 2 Barbara Scheffner 2017-02-20 00:14:31 UTC

https://bugs.kde.org/show_bug.cgi?id=376391
is also related.

Comment 3 caulier.gilles 2017-05-15 15:35:11 UTC

Git commit 112215b78a7cc9679a050c470444543b9db3a60b by Gilles Caulier.
Committed on 15/05/2017 at 15:29.
Pushed by cgilles into branch 'master'.

add new GPS bookmarks manager for Geolocation Editor
remove KF5::Bookmarks dependency which do not wrok with AppImage, MacOS bundle and Windows installer,
due to run-time dependencies and DBus requirements.
Implementation is not yet finalized and need to be polished before 5.6.0 release, especially to be able to import older
GPS bookmarks generated by DK < 5.6.0
Related: bug 376391, bug 376074, bug 374710, bug 376407

M  +0    -3    CMakeLists.txt
M  +0    -4    app/CMakeLists.txt
M  +8    -18   utilities/geolocation/editor/CMakeLists.txt
A  +273  -0    utilities/geolocation/editor/bookmark/bookmarknode.cpp     [License: GPL (v2+)]
A  +114  -0    utilities/geolocation/editor/bookmark/bookmarknode.h     [License: GPL (v2+)]
A  +325  -0    utilities/geolocation/editor/bookmark/bookmarksdlg.cpp     [License: GPL (v2+)]
A  +132  -0    utilities/geolocation/editor/bookmark/bookmarksdlg.h     [License: GPL (v2+)]
A  +301  -0    utilities/geolocation/editor/bookmark/bookmarksmenu.cpp     [License: GPL (v2+)]
A  +137  -0    utilities/geolocation/editor/bookmark/bookmarksmenu.h     [License: GPL (v2+)]
A  +726  -0    utilities/geolocation/editor/bookmark/bookmarksmngr.cpp     [License: GPL (v2+)]
A  +236  -0    utilities/geolocation/editor/bookmark/bookmarksmngr.h     [License: GPL (v2+)]
M  +37   -25   utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.cpp
M  +17   -11   utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.h
M  +63   -52   utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp
M  +20   -18   utilities/geolocation/editor/bookmark/gpsbookmarkowner.h
M  +7    -40   utilities/geolocation/editor/dialog/geolocationedit.cpp
M  +14   -31   utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp
M  +3    -9    utilities/geolocation/editor/items/gpsimagelistcontextmenu.h
M  +6    -25   utilities/geolocation/editor/searches/searchwidget.cpp
M  +1    -7    utilities/geolocation/editor/searches/searchwidget.h

https://commits.kde.org/digikam/112215b78a7cc9679a050c470444543b9db3a60b

Comment 4 caulier.gilles 2017-05-17 10:10:07 UTC

Git commit 95b5cec4970939d5068ca13ce3e3198fc929cc5b by Gilles Caulier.
Committed on 17/05/2017 at 10:04.
Pushed by cgilles into branch 'master'.

remove menu and toolbar bookmarks management from GPS bookmarks manager.
Now a first version suitable is available. More improvements will come later.
Import form older GPS bookmarks generated bu KF5::bookmarks run fine as well.
Related: bug 376074, bug 376391, bug 374710, bug 376407
FIXED-IN: 5.6.0

M  +11   -5    utilities/geolocation/editor/bookmark/bookmarksdlg.cpp
M  +2    -2    utilities/geolocation/editor/bookmark/bookmarksmenu.cpp
M  +6    -123  utilities/geolocation/editor/bookmark/bookmarksmngr.cpp
M  +0    -2    utilities/geolocation/editor/bookmark/bookmarksmngr.h
M  +1    -1    utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp
M  +23   -19   utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp

https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b