Bug 376680

Summary:	mimetype icons not suitable for dark themes
Product:	[Plasma] Breeze	Reporter:	Janek Bevendorff <kde>
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, alexlong92, kainz.a, mail
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-icons/cd0bb713325459cfd6e89c2ba2418f9e0f0fdc1f	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Project Explorer Icons

Description Janek Bevendorff 2017-02-19 17:02:57 UTC

The file type icons inside the Projects, Classes, Documents and Filesystem panels don't work well with dark UI themes. Some icons which are taken directly from the Breeze theme work okay, but the majority of (custom) icons is hardly recognizable.

This includes icons for the following file types (list is non-exhaustive): *.c, *.cpp,, *.cxx *.h, *.hpp, *.hxx, *.ui, *.xml

*.json and *.sig seem to be breeze icons, but they are also not very well distinguishable.

The non-breeze icons also tend to look very pixelized despite their tiny size.

Comment 1 Aleix Pol 2017-02-19 22:59:56 UTC

Can you please send a screenshot of what you mean?

Comment 2 Janek Bevendorff 2017-02-20 00:34:53 UTC

Created attachment 104121 [details]
Project Explorer Icons

Sure. There you go.

Comment 3 Francis Herne 2017-02-20 17:15:36 UTC

There's another bug there also; it's using the 'C' icon for .h files.

(unless the row is selected, when the correct icon is used. That's weird.)

Comment 4 andreas 2017-02-20 18:17:35 UTC

The .h - .c bug is already fixed. about the color I'll fix it asap.

Comment 5 Alex L 2017-04-27 23:28:14 UTC

Why using the C icon for .h files would be a bug? It has a different color to distinguish it from .c icon. Using the C for .h files is intended to stress they are C headers.

Comment 6 andreas 2017-07-09 15:47:21 UTC

Git commit cd0bb713325459cfd6e89c2ba2418f9e0f0fdc1f by andreas kainz.
Committed on 09/07/2017 at 15:46.
Pushed by andreask into branch 'master'.

update .h and .h++ colors

M  +1    -1    icons-dark/mimetypes/16/text-x-c++hdr.svg
M  +1    -1    icons-dark/mimetypes/16/text-x-chdr.svg
M  +6    -133  icons-dark/mimetypes/22/text-x-c++hdr.svg
M  +5    -5    icons-dark/mimetypes/22/text-x-chdr.svg
M  +107  -28   icons-dark/mimetypes/32/text-x-c++hdr.svg
M  +29   -38   icons-dark/mimetypes/32/text-x-chdr.svg
M  +140  -28   icons-dark/mimetypes/64/text-x-c++hdr.svg
M  +29   -5    icons-dark/mimetypes/64/text-x-chdr.svg
M  +1    -1    icons/mimetypes/16/text-x-c++hdr.svg
M  +1    -1    icons/mimetypes/16/text-x-chdr.svg
M  +6    -133  icons/mimetypes/22/text-x-c++hdr.svg
M  +5    -5    icons/mimetypes/22/text-x-chdr.svg
M  +107  -28   icons/mimetypes/32/text-x-c++hdr.svg
M  +29   -38   icons/mimetypes/32/text-x-chdr.svg
M  +140  -28   icons/mimetypes/64/text-x-c++hdr.svg
M  +29   -5    icons/mimetypes/64/text-x-chdr.svg

https://commits.kde.org/breeze-icons/cd0bb713325459cfd6e89c2ba2418f9e0f0fdc1f