Bug 376615

Summary:	Missing icon in GNOME shell dock
Product:	[Applications] digikam	Reporter:	Craig Drummond <craig>
Component:	Portability-Interroperability	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, metzpinguin
Priority:	NOR
Version:	5.4.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:	6.0.0
Sentry Crash Report:
Attachments:	GNOME dock

Description Craig Drummond 2017-02-18 14:56:41 UTC

GNOME shell appears to use the values from WM_CLASS to match a window with its associated .desktop file. This breaks for Digikam5 as its desktop file is org.kde.digikam.desktop but WM_CLASS just has 'digikam' Therefore the generic fallback icon s used in GNOME shells dock.

This can easily be resolved by renaming the .desktop file to digikam.desktop - but I think the existing name is the correct name for these files. Therefore, the other fix would be to use org.kde.digikam in WM_CLASS

Perhaps this is really a GNOME shell issue - but matching WM_CLASS to the .desktop file does seem like the correct thing to do.

Comment 1 caulier.gilles 2017-02-18 15:52:54 UTC

This must be fixed in next 5.5.0.

Please check 5.5.0 pre release of digiKam AppImage bundle available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier

Comment 2 caulier.gilles 2017-02-21 17:18:52 UTC

Craig, 

Any feedback here using current 5.5.0 pre release ?

Gilles Caulier

Comment 3 caulier.gilles 2017-02-23 12:23:17 UTC

Following bug #376369 this problem must be fixed with 5.5.0

Giles Caulier

Comment 4 Craig Drummond 2017-03-20 20:33:23 UTC

Created attachment 104655 [details]
GNOME dock

Comment 5 Craig Drummond 2017-03-20 20:40:19 UTC

This is does not appwar to be fixed in 5.5.0

I've attached a screenshot that shows 2 digikam icons. The top one is the launcher icon added to favourites, the second comes from the running digikam instance.

Comment 6 caulier.gilles 2019-02-03 10:30:38 UTC

Git commit b8317a7c121f5fa407a9ba250615c7536c125f56 by Gilles Caulier.
Committed on 03/02/2019 at 10:27.
Pushed by cgilles into branch 'master'.

add StartupWMClass property to desktop files
Related: bug 378253, bug 381739, bug 375345

M  +1    -0    core/app/main/org.kde.digikam.desktop
M  +1    -0    core/showfoto/main/org.kde.showfoto.desktop

https://commits.kde.org/digikam/b8317a7c121f5fa407a9ba250615c7536c125f56

Comment 7 caulier.gilles 2019-02-03 10:32:23 UTC

Git commit 473d13879eb43b868a4e072049141e04e0bdbcd3 by Gilles Caulier.
Committed on 03/02/2019 at 10:31.
Pushed by cgilles into branch 'development/dplugins'.

add StartupWMClass property to desktop files
Related: bug 378253, bug 381739, bug 375345

M  +1    -0    core/app/main/org.kde.digikam.desktop
M  +1    -0    core/showfoto/main/org.kde.showfoto.desktop

https://commits.kde.org/digikam/473d13879eb43b868a4e072049141e04e0bdbcd3

Comment 8 caulier.gilles 2019-02-03 17:05:04 UTC

Fixed with AppImage digikam-6.0.0-20190203T151814-x86-64.appimage available here :

https://files.kde.org/digikam/

See bug #378253 for details...

Gilles Caulier