Summary: | kwin compile error in Gentoo gcc-6.3.0, glibc-2.25 | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Ясен <iasen.stoianov> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bhush94, johannes.hirte, plasma-bugs |
Priority: | NOR | ||
Version: | 5.9.2 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kwin/35c278e525377723028a1417a705d28517fa183f | Version Fixed In: | |
Attachments: | for Gentoo |
Description
Ясен
2017-02-15 07:09:12 UTC
Please figure out which header file needs to be included for major and include that in logind.cpp. It compiles on my system, thus I cannot help there. Created attachment 104110 [details]
for Gentoo
(In reply to Martin Gräßlin from comment #1) > Please figure out which header file needs to be included for major and > include that in logind.cpp. It compiles on my system, thus I cannot help > there. Well thank you. * The inclusion of <sys/sysmacros.h> by <sys/types.h> is deprecated. This means that in a future release, the macros “major”, “minor”, and “makedev” will only be available from <sys/sysmacros.h>. This one was already fixed by commit 03f4f972d6c3ed03eab04c889248d089d317d370 but reverted later with commit a1f21f3ceac5315f2bfed8e9fa739d71ae2c6f10 > This one was already fixed by commit
> 03f4f972d6c3ed03eab04c889248d089d317d370
> but reverted later with commit
> a1f21f3ceac5315f2bfed8e9fa739d71ae2c6f10
Yay, I love it if we can pick between compile failure on Linux and BSD.
I would appreciate if the devs who thought it needed to move the macros
go to all depending software and fix it.
Git commit 35c278e525377723028a1417a705d28517fa183f by Andreas Sturmlechner. Committed on 25/07/2017 at 20:16. Pushed by asturmlechner into branch 'master'. Fix build with future glibc (major/minor macros), BSD compatible Summary: Also adding sys/types.h which is not implicitly included from all over. Thanks-to: [ade] in #kde-devel See also: https://sourceware.org/ml/libc-alpha/2015-11/msg00452.html https://git.reviewboard.kde.org/r/127662/ Reviewers: #plasma, graesslin Reviewed By: #plasma, graesslin Subscribers: graesslin, plasma-devel, kwin, #kwin, adridg Tags: #plasma Differential Revision: https://phabricator.kde.org/D6175 M +4 -0 logind.cpp https://commits.kde.org/kwin/35c278e525377723028a1417a705d28517fa183f |