Bug 376484

Summary: [Regresion] SDDM-kcm action'Clear Image' is breaking the Breeze sddm theme configuration file
Product: [Applications] systemsettings Reporter: Rog131 <samrog131>
Component: kcm_sddmAssignee: David Edmundson <kde>
Status: RESOLVED FIXED    
Severity: normal CC: bugseforuns, samrog131
Priority: NOR    
Version First Reported In: 5.9.1   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: https://commits.kde.org/sddm-kcm/1c77df276e459e56b51e1a1e6accea3682b4033c Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: A patch to check if the mBackgroundPath is empty.

Description Rog131 2017-02-14 16:24:40 UTC 
Created attachment 104032 [details]
A patch to check if the mBackgroundPath is empty.

How to reproduce:

1) Set the SDDM theme background image - 'Load from file...'.
2) Clear the background image from the sddm-kcm - 'ClearImage'.

The Breeze SDDM theme is showing white background.

The background image is removed from the /usr/share/sddm/themes/breeze/ but the /usr/share/sddm/themes/breeze/theme.conf.user still has the 'type=image'.

A workaround is to remove the theme.conf.user.

This bug was introduced with the https://cgit.kde.org/sddm-kcm.git/commit/?id=19e83b28161783d570bde2ced692a8b5f2236693

The commit is a fix to the https://bugs.kde.org/show_bug.cgi?id=370521 .

A possible fix is to add check is the mBackgroundPath is empty. Adding a patch - working at here.
Comment 1 David Edmundson 2017-02-14 17:02:03 UTC 
Git commit 1c77df276e459e56b51e1a1e6accea3682b4033c by David Edmundson.
Committed on 14/02/2017 at 17:01.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Check the background is valid when choosing background type

Summary:
I rushed in an emergency fix for 5.9.1 that added support for setting
the background type, which was a new property someone added to the
breeze theme in 5.9.1.

My last patch doesn't support clearing the background properly.
Effectively the old code would always set the type to "image".

Test Plan:
Set background to image. Checked config
Cleared background. Checked config

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4611

M  +6    -4    src/themeconfig.cpp

https://commits.kde.org/sddm-kcm/1c77df276e459e56b51e1a1e6accea3682b4033c
Comment 2 Rog131 2017-02-14 17:45:16 UTC 
Thank you - that was quick.