Summary: | Release 16.12.x on i386 tests TestDMS and TestCachingDms fails - other architectures all pass | ||
---|---|---|---|
Product: | [Applications] kstars | Reporter: | Rik Mills <rikmills> |
Component: | general | Assignee: | Jasem Mutlaq <mutlaqja> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | csaba.kertesz, panfaust |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Kubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Rik Mills
2017-02-13 11:05:56 UTC
For the record this patch we added in out packaging git solved it for me: https://git.launchpad.net/~kubuntu-packagers/kubuntu-packaging/+git/kstars/commit/?id=e4aa0177a79f6750a64d2d1060e8d54da8a9fb6d If it's ok we can send a more complete patch replacing the unsafe QVERIFY's with qFuzzyCompare's (In reply to José Manuel Santamaría Lema from comment #1) > this patch we added in out packaging git * in our packaging git repository I would like to just drop a link to the documetation about the macro in question: http://doc.qt.io/qt-5/qtglobal.html#qFuzzyCompare Yes please the complete patch. https://phabricator.kde.org/D4659 By the way, the first patch is wrong. qFuzzyCompare() is a function returning a boolean and therefore it must be use _inside_ a QVERIFY I adapted the patch to the latest source changes and the tests run successfully. The fix is pushed to master: https://commits.kde.org/kstars/fa79fc4faf2c9810f849b980165b5dda0b33f8a3 Thanks for the contribution! |