Bug 376423

Summary: Inconsistent ENTER key in thumbnails view
Product: [Applications] digikam Reporter: Bill Goodman <bg+kdex>
Component: Thumbs-ImageAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version: 5.5.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/digikam/aa084a182beef888ae601506550c89b2d7a74610 Version Fixed In: 5.5.0
Sentry Crash Report:

Description Bill Goodman 2017-02-12 22:54:58 UTC 
The action of the ENTER key is inconsistent in the thumbnails view.

With an image selected in the thumbnails view, hitting the ENTER key sometimes opens the preview view and sometimes does nothing.

To reproduce, double-click an image in the thumbnails view to open the preview window. Exit the preview window by pressing the ESCAPE key. At this point, you can move the selection to different images using the UP/DOWN/LEFT/RIGHT arrow keys. Pressing ENTER will open the selected image in preview. This is the desired operation (in my opinion).

If, instead of using the arrow keys, you move the selection to another image by clicking on it with the mouse, the ENTER key will NOT open the preview. This also seems to be the default mode when the thumbnail view is first opened.
Comment 1 caulier.gilles 2017-02-13 03:46:42 UTC 
I think this problem have been fixed in next release.

Take a look to 5.5.0 pre version available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 2 Bill Goodman 2017-02-13 23:40:00 UTC 
(In reply to caulier.gilles from comment #1)
> I think this problem have been fixed in next release.
> 
> Take a look to 5.5.0 pre version available here :
> 
> https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM
> 
> Gilles Caulier

I installed the version above on Windows 7. The issue is still there. ENTER has no effect after the selection is changed with a mouse click.
Comment 3 Maik Qualmann 2017-02-15 19:36:49 UTC 
I can confirm the behavior from the Enter key on Linux. Actually, the F3 key is to call the preview. There is really no code that prompts the Enter key for the preview. I look at it.

Maik
Comment 4 Bill Goodman 2017-02-15 19:46:30 UTC 
There is a configuration setting (Views>Icons>Thumbnail click action) which selects either preview or image editor. This seems to be for a "double-click" action in spite of the name saying "click".

It seems natural to me for the ENTER key to do the same action that double-click does in this context.
Comment 5 caulier.gilles 2017-02-15 20:02:42 UTC 
Maik,

If i remember, the Enter key must be catch by Captions/Tags right sidebar. There is an event handler about keys.

Gilles
Comment 6 Maik Qualmann 2017-02-15 21:07:29 UTC 
The cause I have found, it comes from the item activation. We save the last mouse event and check the click area. This is bad with the Enter key. I am looking for a clean solution...

Maik
Comment 7 Maik Qualmann 2017-02-15 21:32:58 UTC 
Git commit aa084a182beef888ae601506550c89b2d7a74610 by Maik Qualmann.
Committed on 15/02/2017 at 21:31.
Pushed by mqualmann into branch 'master'.

fix inconsistent item activation with Enter key after mouse actions
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +2    -1    libs/widgets/itemview/itemviewcategorized.cpp

https://commits.kde.org/digikam/aa084a182beef888ae601506550c89b2d7a74610