Summary: | Add geolocation favorites to menu and shortcuts | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | tuxflo <flo.hennig> |
Component: | Usability-Keyboard | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | caulier.gilles, laurakittyinka |
Priority: | NOR | ||
Version: | 5.4.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b | Version Fixed In: | 5.6.0 |
Sentry Crash Report: |
Description
tuxflo
2017-02-12 10:25:42 UTC
What exactly do you mean by "created some favorite locations in the geolocation editor"? Did you use "Create Bookmark" from the context menu? Yes! I mean "Bookmarks" not favorites. Sorry for the vagueness. No problem! Unfortunately I have to tell you that this will appear in the digiKam handbook with the next release: --------------------- The Display-bookmarked-positions-on-the-map button is not working at the time of writing because the whole bookmark issue needs to be reorganized. This also affects the Bookmarks->Edit Bookmarks... item in the context menu on the list of images below the map and the Add Bookmark item in the context menu on the map. Warning: The use of Add Bookmark in the context menu on the map can lead to loss of your bookmarks in Marble! --------------------- But your idea is very good. So I would vote to keep this on the wishlist. It only might take some time because right now we are quite busy with a lot of other issues, sorry! Git commit 112215b78a7cc9679a050c470444543b9db3a60b by Gilles Caulier. Committed on 15/05/2017 at 15:29. Pushed by cgilles into branch 'master'. add new GPS bookmarks manager for Geolocation Editor remove KF5::Bookmarks dependency which do not wrok with AppImage, MacOS bundle and Windows installer, due to run-time dependencies and DBus requirements. Implementation is not yet finalized and need to be polished before 5.6.0 release, especially to be able to import older GPS bookmarks generated by DK < 5.6.0 Related: bug 376687, bug 376074, bug 374710, bug 376407 M +0 -3 CMakeLists.txt M +0 -4 app/CMakeLists.txt M +8 -18 utilities/geolocation/editor/CMakeLists.txt A +273 -0 utilities/geolocation/editor/bookmark/bookmarknode.cpp [License: GPL (v2+)] A +114 -0 utilities/geolocation/editor/bookmark/bookmarknode.h [License: GPL (v2+)] A +325 -0 utilities/geolocation/editor/bookmark/bookmarksdlg.cpp [License: GPL (v2+)] A +132 -0 utilities/geolocation/editor/bookmark/bookmarksdlg.h [License: GPL (v2+)] A +301 -0 utilities/geolocation/editor/bookmark/bookmarksmenu.cpp [License: GPL (v2+)] A +137 -0 utilities/geolocation/editor/bookmark/bookmarksmenu.h [License: GPL (v2+)] A +726 -0 utilities/geolocation/editor/bookmark/bookmarksmngr.cpp [License: GPL (v2+)] A +236 -0 utilities/geolocation/editor/bookmark/bookmarksmngr.h [License: GPL (v2+)] M +37 -25 utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.cpp M +17 -11 utilities/geolocation/editor/bookmark/gpsbookmarkmodelhelper.h M +63 -52 utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp M +20 -18 utilities/geolocation/editor/bookmark/gpsbookmarkowner.h M +7 -40 utilities/geolocation/editor/dialog/geolocationedit.cpp M +14 -31 utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp M +3 -9 utilities/geolocation/editor/items/gpsimagelistcontextmenu.h M +6 -25 utilities/geolocation/editor/searches/searchwidget.cpp M +1 -7 utilities/geolocation/editor/searches/searchwidget.h https://commits.kde.org/digikam/112215b78a7cc9679a050c470444543b9db3a60b Git commit 95b5cec4970939d5068ca13ce3e3198fc929cc5b by Gilles Caulier. Committed on 17/05/2017 at 10:04. Pushed by cgilles into branch 'master'. remove menu and toolbar bookmarks management from GPS bookmarks manager. Now a first version suitable is available. More improvements will come later. Import form older GPS bookmarks generated bu KF5::bookmarks run fine as well. Related: bug 376687, bug 376074, bug 374710, bug 376407 FIXED-IN: 5.6.0 M +11 -5 utilities/geolocation/editor/bookmark/bookmarksdlg.cpp M +2 -2 utilities/geolocation/editor/bookmark/bookmarksmenu.cpp M +6 -123 utilities/geolocation/editor/bookmark/bookmarksmngr.cpp M +0 -2 utilities/geolocation/editor/bookmark/bookmarksmngr.h M +1 -1 utilities/geolocation/editor/bookmark/gpsbookmarkowner.cpp M +23 -19 utilities/geolocation/editor/items/gpsimagelistcontextmenu.cpp https://commits.kde.org/digikam/95b5cec4970939d5068ca13ce3e3198fc929cc5b Glad to see that theres a process here and the issue is set to "Fixed" but I just tested version 5.6 and there is no possibility to add geolocation bookmarks to images. Perhaps I overlooked something? yes you can. It's in Geolocation Editor, from contextual menu, as you can see in this example : https://www.flickr.com/photos/digikam/34074731223/in/dateposted-public/ Gilles Caulier Ah I see! My main problem with this issue is, that its inconvenient to open the selected files in the geolocation editor first (here it takes about 2-5 seconds until the editor is loaded). My idea was to add this functionality to the default right click context menu, where one can already set Tags or Labels to a selection of images. Ok, now i understand. This require to add GPS bookmark management visible outside the GPS Editor. This is not the case yet. Please open a new file with a more explicit title and description. This one is closed, a new one must be open. Thanks in advance Gilles Caulier |