| Summary: | Screenshots of single window can be sized wrongly | ||
|---|---|---|---|
| Product: | [Applications] Spectacle | Reporter: | Jonathan Riddell <jr> |
| Component: | General | Assignee: | Boudhayan Gupta <me> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | be.0, bugseforuns |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/spectacle/db2231ae618add67c26bc88c2e327d3512993245 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
kfloppy from spectacle
Mixxx Preferences window |
||
This happens with any QDialog main window app such as Spectacle itself. It doesn't happen with a resized Konsole for example. Created attachment 108890 [details]
Mixxx Preferences window
another screenshot of the bug
Git commit db2231ae618add67c26bc88c2e327d3512993245 by Nathaniel Graham, on behalf of Alex Nemeth.
Committed on 21/02/2018 at 04:53.
Pushed by ngraham into branch 'master'.
Fix capturing QDialog that included the whole desktop area
Summary:
QDialog may add a 1x1 sized desktop window in the top left corner when capturing with Window Under Cursor.
Now it ignores that.
Test Plan:
Before:
{F5719291}
After:
{F5719290}
Reviewers: #spectacle, rkflx, ngraham
Reviewed By: #spectacle, rkflx, ngraham
Subscribers: ngraham
Tags: #spectacle
Differential Revision: https://phabricator.kde.org/D10673
M +8 -1 src/PlatformBackends/X11ImageGrabber.cpp
https://commits.kde.org/spectacle/db2231ae618add67c26bc88c2e327d3512993245
|
Created attachment 103978 [details] kfloppy from spectacle I took a screenshot of essential KDE application KFloppy which has a small window. Boud was standing behind me and jinxed it and the screenshot was much larger than the window with transparent fill.