Bug 376339

Summary:	frameworks branch: Press ENTER on manual price entry does not save the new price
Product:	[Applications] kmymoney	Reporter:	Robby Engelmann <robby.engelmann>
Component:	general	Assignee:	KMyMoney Devel Mailing List <kmymoney-devel>
Status:	RESOLVED FIXED
Severity:	minor	CC:	lukasz.wojnilowicz, robby.engelmann
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	https://commits.kde.org/kmymoney/7ec4b4006678812b8954a1db5f4c7b990fbe26fc	Version Fixed In:	5.0.0

Description Robby Engelmann 2017-02-11 06:27:50 UTC

As stated in the summary.:

-->Prices -->New -->Enter new price -->hit ENTER --> old price is kept
-->Prices -->New -->Enter new price  -->click OK --> new price is taken

Expected: New price taken on ENTER and OK-Click.

Comment 1 NSLW 2017-07-30 05:43:44 UTC

Maybe you don't see the price changed. Ensure you have "Show all stored prices" checked on "Price Editor - KMyMoney" dialog.

Comment 2 Robby Engelmann 2017-07-30 11:48:58 UTC

checked it again today. It is still the same as described.
NSLW: Do you really use KMM from master branch (latest git)???

Comment 3 NSLW 2017-07-30 14:31:47 UTC

(In reply to Robby Engelmann from comment #2)
> checked it again today. It is still the same as described.
> NSLW: Do you really use KMM from master branch (latest git)???

Ok. Now I see the problem. That would need a fix.

Comment 4 Thomas Baumgart 2017-07-30 16:35:28 UTC

Wait a second guys: Robby wrote today at 2017-07-30 11:48:58 UTC that it still does not work on latest git. I added my fix at 2017-07-30 11:40:xx UTC to the repo (so just a few minutes before). Did you use that version (7ec4b4006678812b8954a1db5f4c7b990fbe26fc) when rerunning the test or a prior one? I just tried it given your original instruction and things work fine. Here's what I do:

-->Prices -->Select security -->New -->multiple TABs to price 
  -->Enter new price -->hit ENTER --> new price is taken

What am I doing wrong to not see the problem if you really used the latest git version containing my fix?

Comment 5 NSLW 2017-07-30 16:39:28 UTC

(In reply to Thomas Baumgart from comment #4)
> Wait a second guys: Robby wrote today at 2017-07-30 11:48:58 UTC that it
> still does not work on latest git. I added my fix at 2017-07-30 11:40:xx UTC
> to the repo (so just a few minutes before). Did you use that version
> (7ec4b4006678812b8954a1db5f4c7b990fbe26fc) when rerunning the test or a
> prior one? I just tried it given your original instruction and things work
> fine. Here's what I do:
> 
> -->Prices -->Select security -->New -->multiple TABs to price 
>   -->Enter new price -->hit ENTER --> new price is taken
> 
> What am I doing wrong to not see the problem if you really used the latest
> git version containing my fix?

:) Your fix works. I just wasn't up to date with my master branch.