| Summary: | Number of photos in gallery | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Marek Potocki <qrczakoff> |
| Component: | Albums-ItemGroup | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, freisim93, metzpinguin |
| Priority: | NOR | ||
| Version: | 5.4.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/68ca663ad26af6395a0ff59a011d7b4ad8e6fa78 | Version Fixed In: | 5.6.0 |
| Sentry Crash Report: | |||
| Attachments: |
I have 3 groups of 4 photos. Counter is'nt 3, but 12.
Show information on grouped items in [] in status bar Show information on grouped items in [] in status bar - 2 |
||
This is expected, but can also be addressed by an upcoming overhaul of grouping behaviour. The reasoning for the current count is, that all operations apply to all items in a group and thus contribute to the count. As this will change, I agree the counts should change back to showing number of visible items. I find the current behavior is absolutely correct. Otherwise, if 2 grouped images are selected, we would have the display "8/3 selected" in the status bar. Maik You could also say 2/3 items? Of course either you count grouped images in selected and total counts or you don't in both numbers. I would say both are valid, but I am not so sure which one is more helpful. (In reply to Simon from comment #3) > You could also say 2/3 items? Of course either you count grouped images > in selected and total counts or you don't in both numbers. I would say > both are valid, but I am not so sure which one is more helpful. It depends on user. For me more helpful is cont of visible elements. for other may be total count. I vote to show both information, something like (2/3) [12 items] Gilles Created attachment 105688 [details] Show information on grouped items in [] in status bar The attached patch displays the information about selected items based on actual selected items, not grouped items. If this information differs with grouped items, these differing numbers are displayed between []. These brackets do not convey the meaning, but there is not enough space to print something verbose (e.g. "with grouped:"). From context it should be clear that this must refer to grouping. Anyone not using grouping won't ever see it, so only users aware of grouping will see this. Related to this I made the metadata and color tab in the right sidebar display the information of the main item in a group, if only one group is selected. Previously it wouldn't display anything, as multiple selection was not supported. Multiple selection still isn't supported, it just considers multiple items of the same group as a single selection. Screenshot: http://i.imgur.com/D2NHjoq.png Patch tested. Here all work fine. I recommend to use a tooltip over the status area where count of item selected is printed, as it's do with filter area from status bar. This will permit to be more comprehensive for end user if a literal comment explain what the number want mean. Gilles Created attachment 105689 [details] Show information on grouped items in [] in status bar - 2 I added tooltips, example screenshot: http://i.imgur.com/E3DPaN3.png Great, let's go Gilles Git commit 68ca663ad26af6395a0ff59a011d7b4ad8e6fa78 by Simon Frei. Committed on 23/05/2017 at 15:16. Pushed by sfrei into branch 'master'. Make bottom status bar and right sidebar more grouping aware FIXED-IN: 5.6.0 M +2 -1 NEWS M +78 -18 app/main/digikamapp.cpp M +0 -1 app/main/digikamapp_p.h M +0 -2 app/views/digikamview.cpp M +2 -2 libs/database/item/imageinfo.h M +36 -0 libs/database/item/imageinfolist.cpp M +7 -0 libs/database/item/imageinfolist.h M +60 -101 libs/imageproperties/imagepropertiessidebardb.cpp https://commits.kde.org/digikam/68ca663ad26af6395a0ff59a011d7b4ad8e6fa78 |
Created attachment 103929 [details] I have 3 groups of 4 photos. Counter is'nt 3, but 12. At bottom of gallery I see number of all filtered files instead of visible, if I have groups.