Bug 376246

Summary: compilation requires xmllint but CMake doesnt' check for it
Product: [Frameworks and Libraries] frameworks-kdoctools Reporter: Allen Winter <winter>
Component: generalAssignee: Documentation Editorial Team <kde-doc-english>
Status: RESOLVED FIXED    
Severity: normal CC: kdelibs-bugs, luigi.toscano
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Allen Winter 2017-02-09 16:32:54 UTC
In the v5.30.0 tag, I found that xmllint is required but the CMake buildsystem doesn't require it.
Comment 1 Luigi Toscano 2017-02-09 16:45:08 UTC
xmllint is part of libxml2, which is checked. Does your distribution split it?
Comment 2 Allen Winter 2017-02-09 17:10:10 UTC
yes, I think its in libxml2-utils on ubuntu 14.04
Comment 3 Luigi Toscano 2017-02-10 23:09:09 UTC
Confirmed, see the proposed review https://phabricator.kde.org/D4558 .
Comment 4 Luigi Toscano 2017-02-11 14:39:56 UTC
Git commit d7e0d20ae5f63a842f3543a8f0eef9afd54e0dbe by Luigi Toscano.
Committed on 11/02/2017 at 14:39.
Pushed by ltoscano into branch 'master'.

Fail the build early if xmllint is not available

Summary:
xmllint is required later anyway, and kio_help has the check.

Test Plan: If xmllint is not available, compilation fails in the cmake phase.

Reviewers: winterz

Reviewed By: winterz

Subscribers: #frameworks, #documentation

Tags: #frameworks, #documentation

Differential Revision: https://phabricator.kde.org/D4558

M  +3    -0    CMakeLists.txt

https://commits.kde.org/kdoctools/d7e0d20ae5f63a842f3543a8f0eef9afd54e0dbe