| Summary: | Window preview on hover + Middle click (close) = all window transparent | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | kolorafa <kde_org> |
| Component: | Task Manager and Icons-Only Task Manager widgets | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | 5.9.1 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/a261ff25a580759183d20725d9f37d9ba25365ee | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
kolorafa
2017-02-09 12:31:59 UTC
This will be fixed soon by https://phabricator.kde.org/D4525 Git commit dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e by Eike Hein. Committed on 13/02/2017 at 10:42. Pushed by hein into branch 'Plasma/5.9'. Fix crash when invoking Present Windows with the group dialog open. Summary: This fixes a regression from aeec4ae8 which unsets the taskManagerItem prop when the group dialog is shown to intentionally break window highlighting while the dialog is open. This patch instead fixes highlighting from the group dialog properly by including it in the highlight list. Also adds some extra crash guards. CCMAIL:bvbfan@abv.bg Related: bug 376205 Reviewers: #plasma, anthonyfieroni Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4525 M +2 -0 applets/taskmanager/package/contents/ui/Task.qml M +2 -1 applets/taskmanager/package/contents/ui/main.qml M +22 -0 applets/taskmanager/plugin/backend.cpp M +6 -0 applets/taskmanager/plugin/backend.h https://commits.kde.org/plasma-desktop/dc17f78ebcc76600040a8d2ef8c57b9a41a8d06e Git commit 61489110c597ad4e4cb69b004d30dbda8b4110ef by Eike Hein. Committed on 13/02/2017 at 18:01. Pushed by hein into branch 'Plasma/5.8'. Fix crash when invoking Present Windows with the group dialog open. Summary: This fixes a regression from aeec4ae8 which unsets the taskManagerItem prop when the group dialog is shown to intentionally break window highlighting while the dialog is open. This patch instead fixes highlighting from the group dialog properly by including it in the highlight list. Also adds some extra crash guards. CCMAIL:bvbfan@abv.bg Related: bug 376205 Reviewers: #plasma, anthonyfieroni Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4525 M +2 -0 applets/taskmanager/package/contents/ui/Task.qml M +2 -1 applets/taskmanager/package/contents/ui/main.qml M +22 -0 applets/taskmanager/plugin/backend.cpp M +6 -0 applets/taskmanager/plugin/backend.h https://commits.kde.org/plasma-desktop/61489110c597ad4e4cb69b004d30dbda8b4110ef Git commit a261ff25a580759183d20725d9f37d9ba25365ee by Eike Hein. Committed on 16/02/2017 at 13:30. Pushed by hein into branch 'master'. Fix crash when invoking Present Windows with the group dialog open. Summary: This fixes a regression from aeec4ae8 which unsets the taskManagerItem prop when the group dialog is shown to intentionally break window highlighting while the dialog is open. This patch instead fixes highlighting from the group dialog properly by including it in the highlight list. Also adds some extra crash guards. CCMAIL:bvbfan@abv.bg Related: bug 376205 Reviewers: #plasma, anthonyfieroni Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D4525 M +2 -0 applets/taskmanager/package/contents/ui/Task.qml M +2 -1 applets/taskmanager/package/contents/ui/main.qml M +22 -0 applets/taskmanager/plugin/backend.cpp M +6 -0 applets/taskmanager/plugin/backend.h https://commits.kde.org/plasma-desktop/a261ff25a580759183d20725d9f37d9ba25365ee Git commit 6e9a81a0291ad6bd3aeee80050ee395f266c3f33 by Nate Graham, on behalf of Fushan Wen. Committed on 20/04/2022 at 17:56. Pushed by ngraham into branch 'master'. applets/taskmanager: Remove `groupDialog` property after switching to Window View It's introduced in a261ff25a580759183d20725d9f37d9ba25365ee to fix window highlighting, but now it's not used anywhere, so remove it. Related: bug 376205, bug 452584 M +0 -1 applets/taskmanager/package/contents/ui/main.qml M +0 -14 applets/taskmanager/plugin/backend.cpp M +0 -6 applets/taskmanager/plugin/backend.h https://invent.kde.org/plasma/plasma-desktop/commit/6e9a81a0291ad6bd3aeee80050ee395f266c3f33 |