| Summary: | fuzzy dynamic is not influenced by "strength" | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Bollebib <kwadraatnope> |
| Component: | Brush engines | Assignee: | Tiar <tamtamy.tymona> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, tamtamy.tymona |
| Priority: | NOR | ||
| Version: | 3.1.2 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/1c65c4c04d84aabcaaa29e9981a3e725a1d26f5a | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Bollebib
2017-02-08 13:16:32 UTC
Fuzzy dab is affected by the curve here, but not by the strength, no. (In reply to wolthera from comment #1) > Fuzzy dab is affected by the curve here, but not by the strength, no. yes, i made a mistake earlier in my config,you are correct,it does work with curves Git commit 3602c72493b78d7e787911e60f3680371778f2ec by Agata Cacko. Committed on 15/08/2019 at 15:42. Pushed by tymond into branch 'master'. Fix Strength not used in Rotation - Fuzzy Dab Before this commit, if you chose Fuzzy Dab sensor in Rotation option, the value of the Strength slider wouldn't affect the resulting rotation of the brush tip. This commit fixes that behaviour: now if you choose very low Strength and the first curve from the template ones, the brush tip will rotate only slightly (before it would rotate within the full 360* range). * Fuzzy Dab is 'additive' kind of sensor, so it's value would be put in 'realAdditivePart' in rotationLikeValue(). 'constant' contains the value of 'Strength' slider. To get it working together, 'realAdditivePart' had to be multiplied by the 'constant' value. * HSV option just ignored the problem and multiplied it by the value of the slider later. It couldn't be done for Rotation because Rotation takes the canvas rotation into account (see rotationLikeValue). Therefore it had to be done inside rotationLikeValue function, not later. Therefore the multiplication in HSV option had to be disabled to not double the effect. BACKPORT:krita/4.2 M +1 -1 plugins/paintops/libpaintop/kis_curve_option.h M +0 -1 plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp https://invent.kde.org/kde/krita/commit/3602c72493b78d7e787911e60f3680371778f2ec Git commit 1c65c4c04d84aabcaaa29e9981a3e725a1d26f5a by Agata Cacko. Committed on 14/09/2019 at 15:25. Pushed by tymond into branch 'krita/4.2'. Fix Strength not used in Rotation - Fuzzy Dab Before this commit, if you chose Fuzzy Dab sensor in Rotation option, the value of the Strength slider wouldn't affect the resulting rotation of the brush tip. This commit fixes that behaviour: now if you choose very low Strength and the first curve from the template ones, the brush tip will rotate only slightly (before it would rotate within the full 360* range). * Fuzzy Dab is 'additive' kind of sensor, so it's value would be put in 'realAdditivePart' in rotationLikeValue(). 'constant' contains the value of 'Strength' slider. To get it working together, 'realAdditivePart' had to be multiplied by the 'constant' value. * HSV option just ignored the problem and multiplied it by the value of the slider later. It couldn't be done for Rotation because Rotation takes the canvas rotation into account (see rotationLikeValue). Therefore it had to be done inside rotationLikeValue function, not later. Therefore the multiplication in HSV option had to be disabled to not double the effect. BACKPORT:krita/4.2 M +1 -1 plugins/paintops/libpaintop/kis_curve_option.h M +0 -1 plugins/paintops/libpaintop/kis_pressure_hsv_option.cpp https://invent.kde.org/kde/krita/commit/1c65c4c04d84aabcaaa29e9981a3e725a1d26f5a |