| Summary: | Shift + Clicking a layer eye icon does not hide other layers | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Michel T Gonzalez <antilopemiope> |
| Component: | Layer Stack | Assignee: | vanyossi <ghevan> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ghevan, griffinvalley, halla, scottpetrovic |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/1ed14db7a6e32031cffb98d97634360d9d52a197 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Michel T Gonzalez
2017-02-06 06:12:44 UTC
I wonder when this broke, and whether it broke when we started using shift-click to select multiple layers, but it is broken... (In reply to Boudewijn Rempt from comment #1) > I wonder when this broke, and whether it broke when we started using > shift-click to select multiple layers, but it is broken... I think it disappeared with the new layers docker. I was talking with Dmitry and it sounds like this was removed as Wolthera pointed out. It also sounds like it wasn't working correctly before as well. The behavior should be the following: 1. Shift + Clicking an eye icon on a layer hides all layers except the one clicked on 2. Shift + Clicking an eye icon again will restore the layers to its previous state It doesn't sound like there is a state management right now for the layers, so there isn't a way to restore the layer visibility to what it was previously. That will have to be added as well with this. I made an implementation (currrently on merge request) But now Im doubtfull this feature make sense when "isolate layer" does something very similar. The shift + click on the patch hides all layers except the layers needed for the clicked layer to be visible (it will not hide their children also). A scon dclick restores the state as it was before. However because there are some other eyes present dmitry found it very confusing. I don't know how this feature is supposed to look, should we disable all eye icons except the one that was clicked? Current patch in revision https://invent.kde.org/kde/krita/merge_requests/5 Git commit 1b156600aac2e42942bf1772b9c418d155061fc4 by Ivan Yossi. Committed on 28/06/2019 at 13:26. Pushed by ivany into branch 'master'. Enable Shift + Click to show only current layer Differential Revision: https://phabricator.kde.org/D20591 M +159 -55 plugins/dockers/layerdocker/NodeDelegate.cpp https://invent.kde.org/kde/krita/commit/1b156600aac2e42942bf1772b9c418d155061fc4 Git commit 1ed14db7a6e32031cffb98d97634360d9d52a197 by Boudewijn Rempt, on behalf of Ivan Yossi. Committed on 08/07/2019 at 14:59. Pushed by rempt into branch 'krita/4.2'. Enable Shift + Click to show only current layer Differential Revision: https://phabricator.kde.org/D20591 M +159 -55 plugins/dockers/layerdocker/NodeDelegate.cpp https://invent.kde.org/kde/krita/commit/1ed14db7a6e32031cffb98d97634360d9d52a197 |