| Summary: | quick brush engine has a hard-coded max size of 1000px | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Raghavendra kamath <raghu> |
| Component: | Brush engines | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | griffinvalley, halla, jtamate, raghu |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krita/388d73946129a4b769b74df6d126ddfe03b681d4 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | The quick brush with a size greater than 1K | ||
|
Description
Raghavendra kamath
2017-02-06 04:34:05 UTC
quickbrush seems to be snapping back as well in particular. Git commit 27a1887ba3cca0cf472fec278ebbe1e653f0151c by Boudewijn Rempt. Committed on 07/02/2017 at 11:19. Pushed by rempt into branch 'master'. M +1 -1 libs/ui/tool/kis_tool_paint.cc https://commits.kde.org/krita/27a1887ba3cca0cf472fec278ebbe1e653f0151c @boud This is still reproducible in git master. I did a clean build but the brush still snaps to 1k Let's reopen it then. I won't be able to do any coding for some time, but if it stays closed, I will forget for sure. Hm, I really cannot reproduce this in git master anymore. Hi Boud, this is only true with the quick brush - brush engine now. The quick brush engine brushes get stuck 1k in master. rest all brush engine ( atleast the ones that I tested work fine without problem.) Sidenote- there is a small hiccup lag notably beyond 1k when resizing brushes with auto brush tips. Yeah, the hickup is normal: it's because at that point the masks are generated for the larger sizes. Those masks are going to take a serious amount of memory, by the way. But weird that the bug happens with specifically the quick brush engine. I guess that one doesn't implement brush resizing correctly. It isn't weird that said bug specifically happens with the quick brush engine: Dmitry had at one point set a hardcap to 1000 for the quickbrush engine because Animtim was able to get it beyond 1000 at the sprint. I see that the quick brush size and the brush size in the toolbar are both limited to 1000px in git version of today (or at least I have not found a brush which allows a bigger size). Is this bug still valid? Yes, it is. Basically, most brush engines follow the max brush diameter setting in the settings dialog, but the quick brush engine doesn't. Created attachment 114941 [details]
The quick brush with a size greater than 1K
If the attached image is the quick brush, the size follows the global limit, in this case of 5000px. (git version of today)
Git commit 7e90373dc7e63210a65002fa029b2813a579a369 by Dmitry Kazakov. Committed on 14/09/2018 at 14:02. Pushed by dkazakov into branch 'master'. Remove hardcoded brush size limit for the Quick Brush M +8 -1 plugins/paintops/roundmarker/kis_roundmarker_option.cpp M +1 -1 plugins/paintops/roundmarker/kis_roundmarkerop_settings.cpp https://commits.kde.org/krita/7e90373dc7e63210a65002fa029b2813a579a369 Git commit 388d73946129a4b769b74df6d126ddfe03b681d4 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 15/09/2018 at 09:08. Pushed by rempt into branch 'krita/4.1'. Remove hardcoded brush size limit for the Quick Brush M +8 -1 plugins/paintops/roundmarker/kis_roundmarker_option.cpp M +1 -1 plugins/paintops/roundmarker/kis_roundmarkerop_settings.cpp https://commits.kde.org/krita/388d73946129a4b769b74df6d126ddfe03b681d4 |