Bug 376068

Summary:	kscreenlocker has unneeded link dependency on libXcursor
Product:	[Unmaintained] kscreenlocker	Reporter:	Viktor Ostashevskyi <ostash>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bshah, johu, mgraesslin, stupor_scurvy343
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/kscreenlocker/dd9a089cfaefb24f012a137618e00005a48b6009	Version Fixed/Implemented In:
Sentry Crash Report:

Description Viktor Ostashevskyi 2017-02-05 17:05:01 UTC

Grepping in sources doesn't show any usage except one line in main CMakeLists.txt:

target_link_libraries(KScreenLocker                                                                                                   
PUBLIC                                                                                                                                
   Qt5::Core                                                                                                                          
   Qt5::X11Extras                                                                                                                     
PRIVATE                                                                                                                               
   KF5::I18n                                                                                                                          
   KF5::IdleTime                                                                                                                      
   KF5::GlobalAccel                                                                                                                   
   KF5::Notifications                                                                                                                 
   KF5::CoreAddons                                                                                                                    
   KF5::ConfigGui                                                                                                                     
   KF5::WindowSystem                                                                                                                  
   ${X11_LIBRARIES}                                                                                                                   
   ${X11_Xcursor_LIB}                                                                                                                 
   XCB::XCB                                                                                                                           
   XCB::KEYSYMS                                                                                                                       
   KF5::WaylandServer                                                                                                                 
   Wayland::Server                                                                                                                    
)

I have a strong feeling it is not needed in CMakeLists.txt

Comment 1 Kai Uwe Broulik 2017-02-08 17:12:43 UTC

Git commit dd9a089cfaefb24f012a137618e00005a48b6009 by Kai Uwe Broulik.
Committed on 08/02/2017 at 17:12.
Pushed by broulik into branch 'master'.

Stop linking X11_Xcursor_LIB in KScreenLocker

It's not used.

Differential Revision: https://phabricator.kde.org/D4505

M  +0    -1    CMakeLists.txt

https://commits.kde.org/kscreenlocker/dd9a089cfaefb24f012a137618e00005a48b6009