Bug 376010

Summary: Import CSV with leading column empty crashes KMyMoney
Product: [Applications] kmymoney Reporter: Frank Osborne <wdd5988>
Component: importerAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: RESOLVED UNMAINTAINED    
Severity: crash CC: lukasz.wojnilowicz
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: attachment-14735-0.html
attachment-4439-0.html
Sample import file.

Description Frank Osborne 2017-02-04 17:04:07 UTC
If the leading column of the import CSV file is empty of data KMyMoney will crash when selecting input columns. I edited the import file to remove empty columns and imported the file with no errors. 
CSV Import component should handle empty columns without crashing. 
Using KMyMoney v 4.14.22
Comment 1 allan 2017-02-04 23:08:04 UTC
This works for me, although on the development branch.

Are you able to provide a similar file that shows the problem, together with details of the columns you were selecting, please.  Is it always the same column that triggers the crash?

I don't recollect anything similar.  Paypay files were a problem a long time back, but that was with the number of columns.

KMyMoney v 4.14.22 is not a valid KMyMoney revision.  You'll find it in the help menu.

Allan
Comment 2 Frank Osborne 2017-02-06 17:15:13 UTC
Created attachment 103867 [details]
attachment-14735-0.html

Allan,
I couldn't duplicate this first try but I'll work on it this week. It may
take me a week or so to get it. You can close this ticket if you want and
I'll let you know when/if I can reproduce it.
I've used Quicken. MS Money, Moneydance, and others and KMyMoney is the
best. You guys did an excellent job.
Thanks for the quick response.
Frank

On Sat, Feb 4, 2017 at 4:08 PM allan <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=376010
>
> --- Comment #1 from allan <agander93@gmail.com> ---
> This works for me, although on the development branch.
>
> Are you able to provide a similar file that shows the problem, together
> with
> details of the columns you were selecting, please.  Is it always the same
> column that triggers the crash?
>
> I don't recollect anything similar.  Paypay files were a problem a long
> time
> back, but that was with the number of columns.
>
> KMyMoney v 4.14.22 is not a valid KMyMoney revision.  You'll find it in the
> help menu.
>
> Allan
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 3 allan 2017-02-18 15:44:03 UTC
Created attachment 104096 [details]
attachment-4439-0.html

Frank
It is with regret that I need to advise you with the sad news that Allan has passed away. He died on the 14 February at home.
I see a number of emails associated with computer based problems, would you be kind enough to pass on the sad news to anyone who knew Allan.
Kind regards
Barbara (sister in law)


Sent from my Samsung device

-------- Original message --------
From: Frank Osborne <bugzilla_noreply@kde.org> 
Date: 06/02/2017  17:15  (GMT+00:00) 
To: kmymoney-devel@kde.org 
Subject: [kmymoney4] [Bug 376010] Import CSV with leading column empty
&nbsp; crashes KMyMoney 

https://bugs.kde.org/show_bug.cgi?id=376010

--- Comment #2 from Frank Osborne <wdd5988@gmail.com> ---
Allan,
I couldn't duplicate this first try but I'll work on it this week. It may
take me a week or so to get it. You can close this ticket if you want and
I'll let you know when/if I can reproduce it.
I've used Quicken. MS Money, Moneydance, and others and KMyMoney is the
best. You guys did an excellent job.
Thanks for the quick response.
Frank

On Sat, Feb 4, 2017 at 4:08 PM allan <bugzilla_noreply@kde.org> wrote:

> https://bugs.kde.org/show_bug.cgi?id=376010
>
> --- Comment #1 from allan <agander93@gmail.com> ---
> This works for me, although on the development branch.
>
> Are you able to provide a similar file that shows the problem, together
> with
> details of the columns you were selecting, please.  Is it always the same
> column that triggers the crash?
>
> I don't recollect anything similar.  Paypay files were a problem a long
> time
> back, but that was with the number of columns.
>
> KMyMoney v 4.14.22 is not a valid KMyMoney revision.  You'll find it in the
> help menu.
>
> Allan
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 4 Frank Osborne 2017-04-12 16:26:28 UTC
Created attachment 104993 [details]
Sample import file.

I can duplicate this error with the attached file. Import the file to a ledger acc't and select the columns for Date, Description etc. When selecting the columns KMyMoney  will crash. 
I get around this by deleting the blank columns in Calc or a text editor. 
Hope this helps,
Frank
Comment 5 wojnilowicz 2017-04-13 12:59:05 UTC
You probably use old version of KMM. In 5.0 version CSV importer underwent huge rewrite so this shouldn't be a problem anymore.

(In reply to Frank Osborne from comment #4)
> Created attachment 104993 [details]
> Sample import file.
> 
> I can duplicate this error with the attached file. Import the file to a
> ledger acc't and select the columns for Date, Description etc. When
> selecting the columns KMyMoney  will crash. 
> I get around this by deleting the blank columns in Calc or a text editor. 
> Hope this helps,
> Frank
Comment 6 Frank Osborne 2017-04-13 14:33:43 UTC
   I'm using v4.6.6. When will v5 be available for Linux? All I see is v
   4.8 on your site.thanks, Frank
   Sent from Nylas Mail[1], the best free email app for work[IMAGE]
   On Apr 13 2017, at 5:59 am, NSLW <bugzilla_noreply@kde.org> wrote:

     https://bugs.kde.org/show_bug.cgi?id=376010
     
     NSLW <lukasz.wojnilowicz@gmail.com> changed:
     
                What    |Removed                     |Added
     ----------------------------------------------------------------------------
                      CC|                            |lukasz.wojnilowicz@gmail.co
                        |                            |m
              Resolution|---                         |UNMAINTAINED
                  Status|UNCONFIRMED                 |RESOLVED
     
     --- Comment #5 from NSLW <lukasz.wojnilowicz@gmail.com> ---
     You probably use old version of KMM. In 5.0 version CSV importer underwent huge
     rewrite so this shouldn't be a problem anymore.
     
     (In reply to Frank Osborne from comment #4)
     > Created attachment 104993 [details]
     > Sample import file.
     > 
     > I can duplicate this error with the attached file. Import the file to a
     > ledger acc't and select the columns for Date, Description etc. When
     > selecting the columns KMyMoney  will crash. 
     > I get around this by deleting the blank columns in Calc or a text editor. 
     > Hope this helps,
     > Frank
     
     -- 
     You are receiving this mail because:
     You reported the bug.   

   

   1. https://n1.nylas.com/link/3849829e5c33828d5db10e9731f2a71e6b0280263a0fd9cd6e7a994b81f9a257/0?redirect=https%3A%2F%2Fnylas.com%3Fref%3Dn1
Comment 7 Jack 2017-04-13 15:39:50 UTC
I would argue against marking 4.x as unmaintained until we actually have a scheduled release date for 5.0, which is not yet the case.  I know we would prefer to avoid additional 4.x releases, but I do wonder if it would be worth backporting some of the fixes, as long as they are not tied in to using any frameworks or other features not available in the older setup.
Comment 8 wojnilowicz 2017-04-13 15:49:39 UTC
(In reply to Jack from comment #7)
> I would argue against marking 4.x as unmaintained until we actually have a
> scheduled release date for 5.0, which is not yet the case.  I know we would
> prefer to avoid additional 4.x releases, but I do wonder if it would be
> worth backporting some of the fixes, as long as they are not tied in to
> using any frameworks or other features not available in the older setup.

Code for CSV Importer is like new code, because old code was so scrambled up that it wasn't functional a lot. It means that fixes will be difficult to backport, but feel free to maintain old code.