Summary: | The 'Show Desktop' action doesn't restore focus | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | razrfalcon |
Component: | core | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bastian.beischer, bhush94, jodr666, kde, martin.ruessler, nate, plasma-bugs, simonandric5 |
Priority: | NOR | Keywords: | reproducible |
Version: | 5.8.5 | Flags: | mgraesslin:
Wayland+
mgraesslin: X11+ mgraesslin: ReviewRequest+ |
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
URL: | https://phabricator.kde.org/D6420 | ||
See Also: | https://bugs.kde.org/show_bug.cgi?id=392289 | ||
Latest Commit: | https://commits.kde.org/kwin/113be5fac81a4b546e2a1b272451f50e777bdcb5 | Version Fixed In: | 5.10.4 |
Description
razrfalcon
2017-02-04 10:33:47 UTC
I have the same setup as you, cn't reproduce on neon unstable. Maybe is already fixed? I can reproduce this on git master. I can also confirm this. Also bug 374954 is a duplicate, I think. *** Bug 374954 has been marked as a duplicate of this bug. *** Given the code in question the problem must exist at least since 5.3 maybe longer. Some investigation results: the problem only exists if there is a desktop window. If there is no desktop window, show desktop properly restores focus. This behavior matches the code which requests focus on the desktop, but does not try to restore. Possible patch at: https://phabricator.kde.org/D6420 Git commit 113be5fac81a4b546e2a1b272451f50e777bdcb5 by Martin Flöser. Committed on 01/07/2017 at 06:20. Pushed by graesslin into branch 'Plasma/5.10'. Restore active client after ending showing desktop Summary: Showing desktop requests focus on the desktop window. This means the active window is reset. When ending showing desktop the state was not restored. This change addresses this problem by requesting focus to the best window. FIXED-IN: 5.10.4 Test Plan: New autotest and manual testing Reviewers: #kwin, #plasma Subscribers: plasma-devel, kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D6420 M +1 -0 autotests/integration/CMakeLists.txt A +128 -0 autotests/integration/showing_desktop_test.cpp [License: GPL (v2)] M +7 -1 workspace.cpp https://commits.kde.org/kwin/113be5fac81a4b546e2a1b272451f50e777bdcb5 |