Bug 375894

Summary:	Case-sensitive text search is a bad default
Product:	[Applications] krusader	Reporter:	Wladimir Palant <psbkde>
Component:	search	Assignee:	Krusader Bugs Distribution List <krusader-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	krusader-bugs-null
Priority:	NOR
Version First Reported In:	Git
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/krusader/3bdf6fe0f39f9490815aaffcc6f64d443829e39a	Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Proposed patch

Description Wladimir Palant 2017-02-02 12:34:58 UTC

I am using Krusader compiled from master (2.5.1-beta, revision 5056272) on Ubuntu 16.04. Right now the default when searching files by text is a case-sensitive search. This is unexpected given that on all other occasions (file names, text search inside lister) the default is case-insensitive search. What's worse, this setting isn't remembered across application restarts so I have to change it again each time I start Krusader.

Steps to reproduce:

1. Start Krusader.
2. Press Ctrl+S to open search dialog.

Actual results:

"Case sensitive" checkbox in File Name section is unchecked, the one in "Containing text" section is checked.

Expected results:

Both checkboxes should be unchecked by default.

Comment 1 Wladimir Palant 2017-02-02 12:41:04 UTC

Created attachment 103774 [details]
Proposed patch

This change reverses the default.

Comment 2 Alex Bikadorov 2017-02-13 20:42:29 UTC

Git commit 3bdf6fe0f39f9490815aaffcc6f64d443829e39a by Alexander Bikadorov, on behalf of Wladimir Palant.
Committed on 13/02/2017 at 20:39.
Pushed by abikadorov into branch 'master'.

#375894 - Use case-insensitive as default for text search

Summary: This reverses the default for case sensitivity when searching for files with particular text.

Test Plan: See STR in bug.

Reviewers: #krusader, martinkostolny, asensi, abika

Reviewed By: #krusader, martinkostolny, asensi, abika

Subscribers: asensi, martinkostolny, abika, #krusader

Tags: #krusader

Differential Revision: https://phabricator.kde.org/D4420

M  +1    -1    krusader/Search/krsearchdialog.cpp

https://commits.kde.org/krusader/3bdf6fe0f39f9490815aaffcc6f64d443829e39a