Bug 375822

Summary: Infinite login loop when wrong credentials are provided by a plugin
Product: [Applications] trojita Reporter: Jan Kundrát <jkt>
Component: IMAPAssignee: Trojita default assignee <trojita-bugs>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://commits.kde.org/trojita/430d6802f44e7262005c1d6413b290bd383c57f0 Version Fixed/Implemented In:
Sentry Crash Report:

Description Jan Kundrát 2017-01-31 22:53:29 UTC 
- save wrong login credentials into trojita's settings
- start trojita, try to go online
- watch the log for an endless loop of login attempts

I would say that this is pretty critical, there's essentially no UI indication for this. That sucks, this definitely used to work in previous releases. It's disappointing that our test suite didn't catch that.

Thanks to Marc Lambrecht (whytrytofly on IRC) for reporting this.
Comment 1 Jan Kundrát 2017-02-13 00:07:22 UTC 
Git commit 430d6802f44e7262005c1d6413b290bd383c57f0 by Jan Kundrát.
Committed on 02/02/2017 at 20:13.
Pushed by gerrit into branch 'master'.

GUI: Do not keep reusing wrong password

Since commit 76648e4248, Trojitá has started forgetting to forget a
cached password which proved to be wrong. When a password was provided
by some plugin, the UI would never ask the user for one after a login
failure. That's suboptimal, especially considering that the code would
just happily loop and issue many login requests using the same
credentials over and over again.

Thanks to Marc Lambrecht (whytrytofly on IRC) for reporting this.

Change-Id: I1920176ad71910bea6e8c83033e444dc01c076bf

M  +8    -0    src/Gui/Window.cpp

https://commits.kde.org/trojita/430d6802f44e7262005c1d6413b290bd383c57f0