Bug 375675

Summary:	wallpaper positioning “Centered” is not previewed and throws error for WallpaperDelegate.qml on console
Product:	[Plasma] plasmashell	Reporter:	Flupp <Flupp+bugs.kde.org>
Component:	Image & Slideshow wallpaper plugins	Assignee:	Marco Martin <notmart>
Status:	RESOLVED FIXED
Severity:	normal	CC:	plasma-bugs-null
Priority:	NOR
Version First Reported In:	5.8.5
Target Milestone:	1.0
Platform:	Arch Linux
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/b6d088d9e6e7239d503cfc9eb281458956877e15	Version Fixed/Implemented In:
Sentry Crash Report:

Description Flupp 2017-01-28 17:38:19 UTC

When choosing the “Positioning” option “Centered” in the “Desktop Settings” for “Wallpaper”s, the previews in the list of available wallpapers are not updated and the following error is logged to the console:

file:///usr/share/plasma/wallpapers/org.kde.image/contents/ui/WallpaperDelegate.qml:68:27: Unable to assign [undefined] to int

The documentation suggests that value QPixmapItem.Pad (cf. WallpaperDelegate.qml:82) is not defined; unfortunately I only found documentation for Qt 4.x:

https://api.kde.org/4.x-api/kde-runtime-apidocs/plasma/declarativeimports/qtextracomponents/html/classQPixmapItem.html#a4437d2f870024d2f5900d57aacfa2a64

Comment 1 David Edmundson 2017-02-28 17:37:04 UTC

Git commit b6d088d9e6e7239d503cfc9eb281458956877e15 by David Edmundson.
Committed on 28/02/2017 at 17:36.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Preview Centered wallpaper as PreserveAspectFit

Summary:
Currently the we create previews with QPixmapItem from KDeclrarative and
when a wallpaper is set to centered sets it to an enum value that
doesn't exist.

PreserveAspectFit displays the wallpaper in the correct proportions as
when it will be applied, but will still be big enough to make it
actually previewable.

Reviewers: #plasma, mart

Reviewed By: mart

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4840

M  +1    -1    wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml

https://commits.kde.org/plasma-workspace/b6d088d9e6e7239d503cfc9eb281458956877e15