Summary: | Dolphin doesn't correctly show directories on a ftp server | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Marco Scarpetta <marcoscarpetta02> |
Component: | general | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdelibs-bugs |
Priority: | NOR | ||
Version: | 5.29.0 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kio/b158255bd590eb333e22526614b1a72611402b6a | Version Fixed In: | 5.31 |
Attachments: | Patch to fix this issue |
Description
Marco Scarpetta
2017-01-27 11:25:26 UTC
Created attachment 103671 [details]
Patch to fix this issue
I looked at the code and solved the issue. I'm attaching a patch if you want to accept it.
Nice, thanks for the patch. https://git.reviewboard.de.org is a better tool for getting patches reviewed though. I would like at least a comment that contains one of the lines that you show in this bug report, so someone can understand (and possibly modify) the parsing code even if the FTP site you mention no longer exists. (yes we should have done that for the other cases too...) The patch looks good otherwise (man we really should have some unittests for this parsing code, to make sure changes don't break anything...). For reference: https://git.reviewboard.kde.org/r/129905/ (thanks!) Git commit b158255bd590eb333e22526614b1a72611402b6a by David Faure, on behalf of Marco Scarpetta. Committed on 01/02/2017 at 11:25. Pushed by dfaure into branch 'master'. Fix parsing of directories listing on a specific ftp server Directories listing on ftp servers like ftp://ftp-dee.poliba.it/ are now parsed correctly. REVIEW: 129905 FIXED-IN: 5.31 M +13 -2 src/ioslaves/ftp/ftp.cpp https://commits.kde.org/kio/b158255bd590eb333e22526614b1a72611402b6a |