Summary: | Specifying a length TagMatch bias has no effect | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Jamie Smith <smithjd15> |
Component: | Playlists/Dynamic Playlists | Assignee: | Amarok Bugs <amarok-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ralf-engels, robert, serhiy.int, tuomas |
Priority: | NOR | ||
Version First Reported In: | 2.9.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/multimedia/amarok/-/commit/04fc4ce57cc1760c975adeddb8870404edce2e09 | Version Fixed In: | |
Sentry Crash Report: |
Description
Jamie Smith
2017-01-25 20:17:15 UTC
Confirming. Version 2.8.0 Using KDE 4.14.22 Kubuntu 16.04 Steps to reproduce: 1. Create a new dynamic playlist. 2. Add Bias "Match meta tag", select tag Length, greater than, put value that only a couple of records should match. Expected result: Only a couple of songs longer than limit appear. Current behaviour: All records appear. Had a look at this. The chosen length in TagMatch is interpreted as milliseconds instead of seconds, causing the lengths to be 1/1000th of the desired ones. I'll see if I manage to fix this sometime soon. Until this is fixed - thanks Tuomas for all your work with amarok - I'm fudging this by hand editing ~/.local/share/amarok/dynamic.xml and changing (without amarok running!) <field>length</field><numValue>6000</numValue> - if 10 minutes to <field>length</field><numValue>6000000</numValue> which seems to work - but making sure I don't attempt to edit the value within amarok. A possibly relevant merge request was started @ https://invent.kde.org/multimedia/amarok/-/merge_requests/94 Git commit 04fc4ce57cc1760c975adeddb8870404edce2e09 by Tuomas Nurmi. Committed on 06/05/2024 at 15:14. Pushed by nurmi into branch 'master'. Fix TagMatchBias to interpret length as seconds M +1 -0 ChangeLog M +12 -3 src/dynamic/biases/TagMatchBias.cpp https://invent.kde.org/multimedia/amarok/-/commit/04fc4ce57cc1760c975adeddb8870404edce2e09 |